2022-10-24 03:08:53

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warnings after merge of the char-misc.current tree

Hi all,

After merging the char-misc.current tree, today's linux-next build
(arm64 defconfig) produced these warnings:

drivers/hwtracing/coresight/coresight-cti-core.c: In functio
n 'cti_enable_hw':
drivers/hwtracing/coresight/coresight-cti-core.c:93:24: warning: unused variable 'dev' [-Wunused-variable]
93 | struct device *dev = &drvdata->csdev->dev;
| ^~~
drivers/hwtracing/coresight/coresight-cti-core.c: In function 'cti_disable_hw':
drivers/hwtracing/coresight/coresight-cti-core.c:154:24: warning: unused variable 'dev' [-Wunused-variable]
154 | struct device *dev = &drvdata->csdev->dev;
| ^~~

Introduced by commit

665c157e0204 ("coresight: cti: Fix hang in cti_disable_hw()")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2022-10-24 06:54:43

by Greg KH

[permalink] [raw]
Subject: Re: linux-next: build warnings after merge of the char-misc.current tree

On Mon, Oct 24, 2022 at 01:57:52PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the char-misc.current tree, today's linux-next build
> (arm64 defconfig) produced these warnings:
>
> drivers/hwtracing/coresight/coresight-cti-core.c: In functio
> n 'cti_enable_hw':
> drivers/hwtracing/coresight/coresight-cti-core.c:93:24: warning: unused variable 'dev' [-Wunused-variable]
> 93 | struct device *dev = &drvdata->csdev->dev;
> | ^~~
> drivers/hwtracing/coresight/coresight-cti-core.c: In function 'cti_disable_hw':
> drivers/hwtracing/coresight/coresight-cti-core.c:154:24: warning: unused variable 'dev' [-Wunused-variable]
> 154 | struct device *dev = &drvdata->csdev->dev;
> | ^~~
>
> Introduced by commit
>
> 665c157e0204 ("coresight: cti: Fix hang in cti_disable_hw()")

Thanks for the report, I have now reverted this in my tree.

greg k-h

2022-10-24 10:24:51

by Suzuki K Poulose

[permalink] [raw]
Subject: Re: linux-next: build warnings after merge of the char-misc.current tree

On 24/10/2022 07:34, Greg KH wrote:
> On Mon, Oct 24, 2022 at 01:57:52PM +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the char-misc.current tree, today's linux-next build
>> (arm64 defconfig) produced these warnings:
>>
>> drivers/hwtracing/coresight/coresight-cti-core.c: In functio
>> n 'cti_enable_hw':
>> drivers/hwtracing/coresight/coresight-cti-core.c:93:24: warning: unused variable 'dev' [-Wunused-variable]
>> 93 | struct device *dev = &drvdata->csdev->dev;
>> | ^~~
>> drivers/hwtracing/coresight/coresight-cti-core.c: In function 'cti_disable_hw':
>> drivers/hwtracing/coresight/coresight-cti-core.c:154:24: warning: unused variable 'dev' [-Wunused-variable]
>> 154 | struct device *dev = &drvdata->csdev->dev;
>> | ^~~
>>
>> Introduced by commit
>>
>> 665c157e0204 ("coresight: cti: Fix hang in cti_disable_hw()")
>
> Thanks for the report, I have now reverted this in my tree.

Apologies ! I will fix this up and send it at rc2

Sorry!

Suzuki

>
> greg k-h