This series adds the missing sound-dai-cells to rt5682s and supplies for
both rt5682s and rt5682.
These properties are already used by sc7180-trogdor.dtsi (and derived
DTs like sc7180-trogdor-kingoftown.dtsi), so the commits in this series
are really just documenting their usage.
v1: https://lore.kernel.org/all/[email protected]/
Changes in v2:
- Changed sound-dai-cells to 1 on rt5682s
- Added commit fixing sound-dai-cells on rt5682
- Added mention to commit messages that properties are already being
used by DTs
Nícolas F. R. A. Prado (4):
ASoC: dt-bindings: realtek,rt5682s: Add #sound-dai-cells
ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies
ASoC: dt-bindings: rt5682: Set sound-dai-cells to 1
ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies
.../devicetree/bindings/sound/realtek,rt5682s.yaml | 7 +++++++
Documentation/devicetree/bindings/sound/rt5682.txt | 8 +++++++-
2 files changed, 14 insertions(+), 1 deletion(-)
--
2.38.1
The rt5682 codec can have three supplies: AVDD, MICVDD and VBAT. They
are already used by sc7180-trogdor.dtsi, so document them in the
binding.
Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
---
Changes in v2:
- Added mention that property is already used in a DT to the commit
message
Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
index 6b87db68337c..c07a1fc7b122 100644
--- a/Documentation/devicetree/bindings/sound/rt5682.txt
+++ b/Documentation/devicetree/bindings/sound/rt5682.txt
@@ -48,6 +48,12 @@ Optional properties:
- #sound-dai-cells: Should be set to '<1>'.
+- AVDD-supply: phandle to the regulator supplying AVDD
+
+- MICVDD-supply: phandle to the regulator supplying MICVDD
+
+- VBAT-supply: phandle to the regulator supplying VBAT
+
Pins on the device (for linking into audio routes) for RT5682:
* DMIC L1
--
2.38.1
The rt5682s codec is a DAI provider with two interfaces - AIF1 and AIF2
- and therefore should have a #sound-dai-cells property that is equal to
1. Add it.
Acked-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
---
Changes in v2:
- Changed commit message
- Changed value to 1
Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
index ca5b8987b749..1c0b06d82369 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
@@ -87,6 +87,9 @@ properties:
maxItems: 2
description: Name given for DAI word clock and bit clock outputs.
+ "#sound-dai-cells":
+ const: 1
+
additionalProperties: false
required:
--
2.38.1
Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells")
defined the sound-dai-cells property as 0. However, rt5682 has two DAIs,
AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix
it.
Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells")
Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
---
Changes in v2:
- Added this commit
Documentation/devicetree/bindings/sound/rt5682.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
index c5f2b8febcee..6b87db68337c 100644
--- a/Documentation/devicetree/bindings/sound/rt5682.txt
+++ b/Documentation/devicetree/bindings/sound/rt5682.txt
@@ -46,7 +46,7 @@ Optional properties:
- realtek,dmic-clk-driving-high : Set the high driving of the DMIC clock out.
-- #sound-dai-cells: Should be set to '<0>'.
+- #sound-dai-cells: Should be set to '<1>'.
Pins on the device (for linking into audio routes) for RT5682:
--
2.38.1
Il 25/10/22 00:00, Nícolas F. R. A. Prado ha scritto:
> Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells")
> defined the sound-dai-cells property as 0. However, rt5682 has two DAIs,
> AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix
> it.
>
> Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells")
> Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
>
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
Il 25/10/22 00:00, Nícolas F. R. A. Prado ha scritto:
> The rt5682s codec is a DAI provider with two interfaces - AIF1 and AIF2
> - and therefore should have a #sound-dai-cells property that is equal to
> 1. Add it.
>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
>
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
On 24/10/2022 18:00, Nícolas F. R. A. Prado wrote:
> The rt5682 codec can have three supplies: AVDD, MICVDD and VBAT. They
> are already used by sc7180-trogdor.dtsi, so document them in the
> binding.
>
> Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
>
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 24/10/2022 18:00, Nícolas F. R. A. Prado wrote:
> Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells")
> defined the sound-dai-cells property as 0. However, rt5682 has two DAIs,
> AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix
> it.
>
> Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells")
> Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On Tue, Oct 25, 2022 at 3:07 AM AngeloGioacchino Del Regno
<[email protected]> wrote:
>
> Il 25/10/22 00:00, Nícolas F. R. A. Prado ha scritto:
> > The rt5682s codec is a DAI provider with two interfaces - AIF1 and AIF2
> > - and therefore should have a #sound-dai-cells property that is equal to
> > 1. Add it.
> >
> > Acked-by: Krzysztof Kozlowski <[email protected]>
> > Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
> >
>
> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
Reviewed-by: Chen-Yu Tsai <[email protected]>
On Mon, Oct 24, 2022 at 3:02 PM Nícolas F. R. A. Prado
<[email protected]> wrote:
>
> Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells")
> defined the sound-dai-cells property as 0. However, rt5682 has two DAIs,
> AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix
> it.
>
> Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells")
> Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
Reviewed-by: Chen-Yu Tsai <[email protected]>