2022-10-17 22:27:44

by Colin Ian King

Subject: [PATCH] esp6: remove redundant variable err

Variable err is being assigned a value that is not read, the assignment
is redundant and so is the variable. Remove it.

Cleans up clang scan warning:
net/ipv6/esp6_offload.c:64:7: warning: Although the value stored to 'err'
is used in the enclosing expression, the value is never actually read
from 'err' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
net/ipv6/esp6_offload.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/ipv6/esp6_offload.c b/net/ipv6/esp6_offload.c
index 79d43548279c..97edf461bc72 100644
--- a/net/ipv6/esp6_offload.c
+++ b/net/ipv6/esp6_offload.c
@@ -56,12 +56,11 @@ static struct sk_buff *esp6_gro_receive(struct list_head *head,
__be32 seq;
__be32 spi;
int nhoff;
- int err;

if (!pskb_pull(skb, offset))
return NULL;

- if ((err = xfrm_parse_spi(skb, IPPROTO_ESP, &spi, &seq)) != 0)
+ if (xfrm_parse_spi(skb, IPPROTO_ESP, &spi, &seq) != 0)
goto out;

xo = xfrm_offload(skb);
--
2.37.3

2022-10-25 08:32:30

by Steffen Klassert

Subject: Re: [PATCH] esp6: remove redundant variable err

On Mon, Oct 17, 2022 at 11:08:09PM +0100, Colin Ian King wrote:
> Variable err is being assigned a value that is not read, the assignment
> is redundant and so is the variable. Remove it.
>
> Cleans up clang scan warning:
> net/ipv6/esp6_offload.c:64:7: warning: Although the value stored to 'err'
> is used in the enclosing expression, the value is never actually read
> from 'err' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>

Applied to ipsec-next, thanks!