2022-10-21 15:15:35

by Ulf Hansson

Subject: [PATCH 2/2] cpuidle: dt: Clarify a comment and simplify code in dt_init_idle_driver()

The drv->state_count is assigned the total number of available states, so
let's make that clear.

Signed-off-by: Ulf Hansson <[email protected]>
---
drivers/cpuidle/dt_idle_states.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/cpuidle/dt_idle_states.c b/drivers/cpuidle/dt_idle_states.c
index 448bc796b0b4..7ca3d7d9b5ea 100644
--- a/drivers/cpuidle/dt_idle_states.c
+++ b/drivers/cpuidle/dt_idle_states.c
@@ -211,12 +211,9 @@ int dt_init_idle_driver(struct cpuidle_driver *drv,
of_node_put(cpu_node);
if (err)
return err;
- /*
- * Update the driver state count only if some valid DT idle states
- * were detected
- */
- if (i)
- drv->state_count = state_idx;
+
+ /* Set the number of total supported idle states. */
+ drv->state_count = state_idx;

/*
* Return the number of present and valid DT idle states, which can
--
2.34.1

2022-10-25 11:49:15

by Sudeep Holla

Subject: Re: [PATCH 2/2] cpuidle: dt: Clarify a comment and simplify code in dt_init_idle_driver()

On Fri, Oct 21, 2022 at 05:10:13PM +0200, Ulf Hansson wrote:
> The drv->state_count is assigned the total number of available states, so
> let's make that clear.
>

Reviewed-by: Sudeep Holla <[email protected]>

--
Regards,
Sudeep