2022-10-25 20:21:22

by William McVicker

Subject: [PATCH v1] kbuild: fix typo in modpost

Commit f73edc8951b2 ("kbuild: unify two modpost invocations") introduced
a typo (moudle.symvers-if-present) which results in the kernel's
Module.symvers to not be included as a prerequisite for
$(KBUILD_EXTMOD)/Module.symvers. Fix the typo to restore the intended
functionality.

Signed-off-by: Will McVicker <[email protected]>
---
scripts/Makefile.modpost | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

base-commit: 1a2dcbdde82e3a5f1db9b2f4c48aa1aeba534fb2

diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
index 8489a3402eb8..e41dee64d429 100644
--- a/scripts/Makefile.modpost
+++ b/scripts/Makefile.modpost
@@ -122,7 +122,7 @@ quiet_cmd_modpost = MODPOST $@
sed 's/ko$$/o/' $(or $(modorder-if-needed), /dev/null) | $(MODPOST) $(modpost-args) -T - $(vmlinux.o-if-present)

targets += $(output-symdump)
-$(output-symdump): $(modorder-if-needed) $(vmlinux.o-if-present) $(moudle.symvers-if-present) $(MODPOST) FORCE
+$(output-symdump): $(modorder-if-needed) $(vmlinux.o-if-present) $(module.symvers-if-present) $(MODPOST) FORCE
$(call if_changed,modpost)

__modpost: $(output-symdump)
--
2.38.0.135.g90850a2211-goog

2022-10-27 16:46:13

by Masahiro Yamada

Subject: Re: [PATCH v1] kbuild: fix typo in modpost

On Wed, Oct 26, 2022 at 5:18 AM Will McVicker <[email protected]> wrote:
>
> Commit f73edc8951b2 ("kbuild: unify two modpost invocations") introduced
> a typo (moudle.symvers-if-present) which results in the kernel's
> Module.symvers to not be included as a prerequisite for
> $(KBUILD_EXTMOD)/Module.symvers. Fix the typo to restore the intended
> functionality.
>
> Signed-off-by: Will McVicker <[email protected]>

Applied to linux-kbuild/fixes.
Thanks!


> ---
> scripts/Makefile.modpost | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> base-commit: 1a2dcbdde82e3a5f1db9b2f4c48aa1aeba534fb2
>
> diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost
> index 8489a3402eb8..e41dee64d429 100644
> --- a/scripts/Makefile.modpost
> +++ b/scripts/Makefile.modpost
> @@ -122,7 +122,7 @@ quiet_cmd_modpost = MODPOST $@
> sed 's/ko$$/o/' $(or $(modorder-if-needed), /dev/null) | $(MODPOST) $(modpost-args) -T - $(vmlinux.o-if-present)
>
> targets += $(output-symdump)
> -$(output-symdump): $(modorder-if-needed) $(vmlinux.o-if-present) $(moudle.symvers-if-present) $(MODPOST) FORCE
> +$(output-symdump): $(modorder-if-needed) $(vmlinux.o-if-present) $(module.symvers-if-present) $(MODPOST) FORCE
> $(call if_changed,modpost)
>
> __modpost: $(output-symdump)
> --
> 2.38.0.135.g90850a2211-goog
>


--
Best Regards
Masahiro Yamada