2022-10-26 11:28:49

by jovial umwari

Subject: [PATCH] staging: most: dim2: hal: aligning function parameters

According to Linux Kernel Coding Style, lines should not end with a '('
Fix-issue reported by checkpatch.pl script.

Signed-off-by: UMWARI JOVIAL <[email protected]>
---
drivers/staging/most/dim2/hal.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
index a5d40b5b138a..6abe3ab2b2cf 100644
--- a/drivers/staging/most/dim2/hal.c
+++ b/drivers/staging/most/dim2/hal.c
@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
dim2_clear_ctr(ctr_addr);
}

-static void dim2_configure_channel(
- u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
- u16 packet_length)
+static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
+ u16 hw_buffer_size, u16 packet_length)
{
dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
--
2.25.1

2022-10-26 13:19:09

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: most: dim2: hal: aligning function parameters

On Wed, Oct 26, 2022 at 02:06:07PM +0300, UMWARI JOVIAL wrote:
> According to Linux Kernel Coding Style, lines should not end with a '('
> Fix-issue reported by checkpatch.pl script.
>
> Signed-off-by: UMWARI JOVIAL <[email protected]>
> ---
> drivers/staging/most/dim2/hal.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

You sent 2 copies of this, but I have no way to determine which one was
correct :(

Please resend a v2 only once so that we know which one is the one to
review.

thanks,

greg k-h