2022-10-27 03:37:32

by Xu Kuohai

Subject: [PATCH bpf-next v2] bpf: Fix a typo in comment for DFS algorithm

From: Xu Kuohai <[email protected]>

There is a typo in comment for DFS algorithm in bpf/verifier.c. The top
element should not be popped until all its neighbors have been checked.
Fix it.

Fixes: 475fb78fbf48 ("bpf: verifier (add branch/goto checks)")
Signed-off-by: Xu Kuohai <[email protected]>
---
kernel/bpf/verifier.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index adf998159897..8c1152c7c289 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -10662,7 +10662,7 @@ static int check_return_code(struct bpf_verifier_env *env)
* 3 let S be a stack
* 4 S.push(v)
* 5 while S is not empty
- * 6 t <- S.pop()
+ * 6 t <- S.peek()
* 7 if t is what we're looking for:
* 8 return t
* 9 for all edges e in G.adjacentEdges(t) do
--
2.30.2

2022-10-27 20:42:32

by patchwork-bot+netdevbpf

Subject: Re: [PATCH bpf-next v2] bpf: Fix a typo in comment for DFS algorithm

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <[email protected]>:

On Wed, 26 Oct 2022 23:44:58 -0400 you wrote:
> From: Xu Kuohai <[email protected]>
>
> There is a typo in comment for DFS algorithm in bpf/verifier.c. The top
> element should not be popped until all its neighbors have been checked.
> Fix it.
>
> Fixes: 475fb78fbf48 ("bpf: verifier (add branch/goto checks)")
> Signed-off-by: Xu Kuohai <[email protected]>
>
> [...]

Here is the summary with links:
- [bpf-next,v2] bpf: Fix a typo in comment for DFS algorithm
https://git.kernel.org/bpf/bpf-next/c/b6d207999c35

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html