2022-10-27 07:47:38

by Mark-PK Tsai (蔡沛剛)

[permalink] [raw]
Subject: [PATCH] dma-buf: cma_heap: Fix typo in comment

Fix typo in comment.

Signed-off-by: Mark-PK Tsai <[email protected]>
---
drivers/dma-buf/heaps/cma_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c
index 28fb04eccdd0..cd386ce639f3 100644
--- a/drivers/dma-buf/heaps/cma_heap.c
+++ b/drivers/dma-buf/heaps/cma_heap.c
@@ -316,7 +316,7 @@ static struct dma_buf *cma_heap_allocate(struct dma_heap *heap,
kunmap_atomic(vaddr);
/*
* Avoid wasting time zeroing memory if the process
- * has been killed by by SIGKILL
+ * has been killed by SIGKILL
*/
if (fatal_signal_pending(current))
goto free_cma;
--
2.18.0



Subject: Re: [PATCH] dma-buf: cma_heap: Fix typo in comment

Il 27/10/22 09:26, Mark-PK Tsai ha scritto:
> Fix typo in comment.
>
> Signed-off-by: Mark-PK Tsai <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>



2022-10-27 13:14:04

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH] dma-buf: cma_heap: Fix typo in comment

On Thu, Oct 27, 2022 at 03:26:38PM +0800, Mark-PK Tsai wrote:
> Fix typo in comment.
>

Comment on what function? I had to see the diff context.

> Signed-off-by: Mark-PK Tsai <[email protected]>
> ---
> drivers/dma-buf/heaps/cma_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c
> index 28fb04eccdd0..cd386ce639f3 100644
> --- a/drivers/dma-buf/heaps/cma_heap.c
> +++ b/drivers/dma-buf/heaps/cma_heap.c
> @@ -316,7 +316,7 @@ static struct dma_buf *cma_heap_allocate(struct dma_heap *heap,

Oh, you refer to cma_heap_allocate(). Please mention it in the patch
description.

> kunmap_atomic(vaddr);
> /*
> * Avoid wasting time zeroing memory if the process
> - * has been killed by by SIGKILL
> + * has been killed by SIGKILL

Duplicated "by"?

Thanks.

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (971.00 B)
signature.asc (235.00 B)
Download all attachments