2022-10-28 01:55:47

by Mark-PK Tsai (蔡沛剛)

[permalink] [raw]
Subject: [PATCH v2] dma-buf: cma_heap: Fix typo in comment

Remove duplicated "by" from comment in cma_heap_allocate().

Signed-off-by: Mark-PK Tsai <[email protected]>
---
drivers/dma-buf/heaps/cma_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c
index 28fb04eccdd0..cd386ce639f3 100644
--- a/drivers/dma-buf/heaps/cma_heap.c
+++ b/drivers/dma-buf/heaps/cma_heap.c
@@ -316,7 +316,7 @@ static struct dma_buf *cma_heap_allocate(struct dma_heap *heap,
kunmap_atomic(vaddr);
/*
* Avoid wasting time zeroing memory if the process
- * has been killed by by SIGKILL
+ * has been killed by SIGKILL
*/
if (fatal_signal_pending(current))
goto free_cma;
--
2.18.0



2022-10-28 04:03:16

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH v2] dma-buf: cma_heap: Fix typo in comment

On Fri, Oct 28, 2022 at 09:44:17AM +0800, Mark-PK Tsai wrote:
> Remove duplicated "by" from comment in cma_heap_allocate().
>

This patch isn't typofix but duplicate word stripping, right? If so, the
patch subject should be "dma-buf: cma_heap: Remove duplicated 'by'".

Thanks.

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (349.00 B)
signature.asc (235.00 B)
Download all attachments

2022-10-28 07:17:24

by Mark-PK Tsai (蔡沛剛)

[permalink] [raw]
Subject: Re: [PATCH v2] dma-buf: cma_heap: Fix typo in comment

> [-- Attachment #1: Type: text/plain, Size: 349 bytes --]
>
> On Fri, Oct 28, 2022 at 09:44:17AM +0800, Mark-PK Tsai wrote:
> > Remove duplicated "by" from comment in cma_heap_allocate().
> >
>
> This patch isn't typofix but duplicate word stripping, right? If so, the
> patch subject should be "dma-buf: cma_heap: Remove duplicated 'by'".

Okay, I've update the title in v3.
Sorry for the horrible commit description.
Thanks.

>
> Thanks.
>
> --

2022-10-28 15:07:57

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH v2] dma-buf: cma_heap: Fix typo in comment

Mark-PK Tsai <[email protected]> writes:

>> [-- Attachment #1: Type: text/plain, Size: 349 bytes --]
>>
>> On Fri, Oct 28, 2022 at 09:44:17AM +0800, Mark-PK Tsai wrote:
>> > Remove duplicated "by" from comment in cma_heap_allocate().
>> >
>>
>> This patch isn't typofix but duplicate word stripping, right? If so, the
>> patch subject should be "dma-buf: cma_heap: Remove duplicated 'by'".
>
> Okay, I've update the title in v3.
> Sorry for the horrible commit description.
> Thanks.

Your original commit description was just fine, you just had the bad
luck to draw the attention of somebody who likes telling other
contributors what to do.

Thanks,

jon