i used checkpatch.pl script to identify the above
Repetition of the same word in one sentence same line
Signed-off-by: UMWARI JOVIAL <[email protected]>
---
drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
index 090345bad223..30a0276b8b58 100644
--- a/drivers/staging/rtl8712/rtl871x_xmit.c
+++ b/drivers/staging/rtl8712/rtl871x_xmit.c
@@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
* If we turn on USE_RXTHREAD, then, no need for critical section.
* Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
*
- * Must be very very cautious...
+ * Must be very cautious...
*
*/
struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)
--
2.25.1
On Fri, Oct 28, 2022 at 08:14:20AM +0300, UMWARI JOVIAL wrote:
> i used checkpatch.pl script to identify the above
> Repetition of the same word in one sentence same line
Please read the documentation for how to write a good changelog text.
Hint, "i" is not something you see in a text, right?
Also, why do you have WARNING in the subject line and not the driver
name? Again, read the documentation please.
>
> Signed-off-by: UMWARI JOVIAL <[email protected]>
> ---
> drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> index 090345bad223..30a0276b8b58 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.c
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.c
> @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
> * If we turn on USE_RXTHREAD, then, no need for critical section.
> * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
> *
> - * Must be very very cautious...
> + * Must be very cautious...
The original text here is correct.
thanks,
greg k-h
Thank you
working on it now
Best Regards
Umwari Jovial
On Fri, 28 Oct 2022 at 09:07, Greg KH <[email protected]> wrote:
>
> On Fri, Oct 28, 2022 at 08:14:20AM +0300, UMWARI JOVIAL wrote:
> > i used checkpatch.pl script to identify the above
> > Repetition of the same word in one sentence same line
>
> Please read the documentation for how to write a good changelog text.
> Hint, "i" is not something you see in a text, right?
>
> Also, why do you have WARNING in the subject line and not the driver
> name? Again, read the documentation please.
>
> >
> > Signed-off-by: UMWARI JOVIAL <[email protected]>
> > ---
> > drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> > index 090345bad223..30a0276b8b58 100644
> > --- a/drivers/staging/rtl8712/rtl871x_xmit.c
> > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c
> > @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
> > * If we turn on USE_RXTHREAD, then, no need for critical section.
> > * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
> > *
> > - * Must be very very cautious...
> > + * Must be very cautious...
>
> The original text here is correct.
>
> thanks,
>
> greg k-h
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Fri, Oct 28, 2022 at 09:13:14AM +0300, jovial umwari wrote:
> Thank you
> working on it now
>
> Best Regards
> Umwari Jovial
As you spell your name this way in emails, please use the same format
for your signed-off-by lines in your patches.
thanks,
greg k-h
Thank you for the corrections
i am very sorry for All these mistakes
i did not know
Best regards
Umwari Jovial
On Fri, 28 Oct 2022 at 09:27, Greg KH <[email protected]> wrote:
>
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
> http://daringfireball.net/2007/07/on_top
>
> On Fri, Oct 28, 2022 at 09:13:14AM +0300, jovial umwari wrote:
> > Thank you
> > working on it now
> >
> > Best Regards
> > Umwari Jovial
>
> As you spell your name this way in emails, please use the same format
> for your signed-off-by lines in your patches.
>
> thanks,
>
> greg k-h
On Fri, Oct 28, 2022 at 08:14:20AM +0300, UMWARI JOVIAL wrote:
> i used checkpatch.pl script to identify the above
> Repetition of the same word in one sentence same line
>
> Signed-off-by: UMWARI JOVIAL <[email protected]>
This is my (not yet automated) response:
You are sending patches to the Outreachy list, in a way
that makes me suspect you have overlooked the Outreachy
Project Contribution Information.
Please review:
https://www.outreachy.org/outreachy-december-2022-internship-round/communities/linux-kernel/ (only accepted applicants can see this link)
https://lore.kernel.org/outreachy/Y0D+dzbjRtuc0KT4@aschofie-mobl2/
Alison
> ---
> drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> index 090345bad223..30a0276b8b58 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.c
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.c
> @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
> * If we turn on USE_RXTHREAD, then, no need for critical section.
> * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
> *
> - * Must be very very cautious...
> + * Must be very cautious...
> *
> */
> struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)
> --
> 2.25.1
>
>
Noted. Thank you sir
On Fri, 28 Oct 2022 at 21:35, Alison Schofield
<[email protected]> wrote:
>
> On Fri, Oct 28, 2022 at 08:14:20AM +0300, UMWARI JOVIAL wrote:
> > i used checkpatch.pl script to identify the above
> > Repetition of the same word in one sentence same line
> >
> > Signed-off-by: UMWARI JOVIAL <[email protected]>
>
> This is my (not yet automated) response:
>
> You are sending patches to the Outreachy list, in a way
> that makes me suspect you have overlooked the Outreachy
> Project Contribution Information.
>
> Please review:
> https://www.outreachy.org/outreachy-december-2022-internship-round/communities/linux-kernel/ (only accepted applicants can see this link)
>
> https://lore.kernel.org/outreachy/Y0D+dzbjRtuc0KT4@aschofie-mobl2/
>
> Alison
>
> > ---
> > drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> > index 090345bad223..30a0276b8b58 100644
> > --- a/drivers/staging/rtl8712/rtl871x_xmit.c
> > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c
> > @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
> > * If we turn on USE_RXTHREAD, then, no need for critical section.
> > * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
> > *
> > - * Must be very very cautious...
> > + * Must be very cautious...
> > *
> > */
> > struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)
> > --
> > 2.25.1
> >
> >
On Sat, 29 Oct 2022, jovial umwari wrote:
> Noted. Thank you sir
Please don't top post. Your reponse should appear below the text that you
are responding to.
julia
>
> On Fri, 28 Oct 2022 at 21:35, Alison Schofield
> <[email protected]> wrote:
> >
> > On Fri, Oct 28, 2022 at 08:14:20AM +0300, UMWARI JOVIAL wrote:
> > > i used checkpatch.pl script to identify the above
> > > Repetition of the same word in one sentence same line
> > >
> > > Signed-off-by: UMWARI JOVIAL <[email protected]>
> >
> > This is my (not yet automated) response:
> >
> > You are sending patches to the Outreachy list, in a way
> > that makes me suspect you have overlooked the Outreachy
> > Project Contribution Information.
> >
> > Please review:
> > https://www.outreachy.org/outreachy-december-2022-internship-round/communities/linux-kernel/ (only accepted applicants can see this link)
> >
> > https://lore.kernel.org/outreachy/Y0D+dzbjRtuc0KT4@aschofie-mobl2/
> >
> > Alison
> >
> > > ---
> > > drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> > > index 090345bad223..30a0276b8b58 100644
> > > --- a/drivers/staging/rtl8712/rtl871x_xmit.c
> > > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c
> > > @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
> > > * If we turn on USE_RXTHREAD, then, no need for critical section.
> > > * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
> > > *
> > > - * Must be very very cautious...
> > > + * Must be very cautious...
> > > *
> > > */
> > > struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)
> > > --
> > > 2.25.1
> > >
> > >
>
>