2022-10-28 08:33:36

by Mark-PK Tsai (蔡沛剛)

Subject: [PATCH v3] dma-buf: cma_heap: Remove duplicated 'by' in comment

Remove duplicated 'by' from comment in cma_heap_allocate().

Signed-off-by: Mark-PK Tsai <[email protected]>
---
drivers/dma-buf/heaps/cma_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c
index 28fb04eccdd0..cd386ce639f3 100644
--- a/drivers/dma-buf/heaps/cma_heap.c
+++ b/drivers/dma-buf/heaps/cma_heap.c
@@ -316,7 +316,7 @@ static struct dma_buf *cma_heap_allocate(struct dma_heap *heap,
kunmap_atomic(vaddr);
/*
* Avoid wasting time zeroing memory if the process
- * has been killed by by SIGKILL
+ * has been killed by SIGKILL
*/
if (fatal_signal_pending(current))
goto free_cma;
--
2.18.0

2022-10-28 13:51:01

by Mukesh Ojha

Subject: Re: [PATCH v3] dma-buf: cma_heap: Remove duplicated 'by' in comment

Hi,

On 10/28/2022 12:25 PM, Mark-PK Tsai wrote:
> Remove duplicated 'by' from comment in cma_heap_allocate().
>
> Signed-off-by: Mark-PK Tsai <[email protected]>
> ---
> drivers/dma-buf/heaps/cma_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c
> index 28fb04eccdd0..cd386ce639f3 100644
> --- a/drivers/dma-buf/heaps/cma_heap.c
> +++ b/drivers/dma-buf/heaps/cma_heap.c
> @@ -316,7 +316,7 @@ static struct dma_buf *cma_heap_allocate(struct dma_heap *heap,
> kunmap_atomic(vaddr);
> /*
> * Avoid wasting time zeroing memory if the process
> - * has been killed by by SIGKILL
> + * has been killed by SIGKILL
> */
> if (fatal_signal_pending(current))
> goto free_cma;


LGTM.

Reviewed-By: Mukesh Ojha <[email protected]>

-Mukesh

2022-10-28 16:46:57

by John Stultz

Subject: Re: [PATCH v3] dma-buf: cma_heap: Remove duplicated 'by' in comment

On Thu, Oct 27, 2022 at 11:55 PM Mark-PK Tsai <[email protected]> wrote:
>
> Remove duplicated 'by' from comment in cma_heap_allocate().
>
> Signed-off-by: Mark-PK Tsai <[email protected]>

Thanks for sending this and going through a few iterations!

Acked-by: John Stultz <[email protected]>

-john

2022-10-31 14:16:11

by AngeloGioacchino Del Regno

Subject: Re: [PATCH v3] dma-buf: cma_heap: Remove duplicated 'by' in comment

Il 28/10/22 08:55, Mark-PK Tsai ha scritto:
> Remove duplicated 'by' from comment in cma_heap_allocate().
>
> Signed-off-by: Mark-PK Tsai <[email protected]>
> Reviewed-By: Mukesh Ojha <[email protected]>
> Acked-by: John Stultz <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>