2022-10-28 12:21:48

by Stephen Kitt

[permalink] [raw]
Subject: [PATCH] dmaengine: sh: Remove unused shdma-arm.h

shdma-arm.h was introduced with commit 1e69653d40f1 ("DMA: shdma: add
r8a73a4 DMAC data to the device ID table"), and its sole user was
removed with commit a19788612f51 ("dmaengine: sh: Remove R-Mobile APE6
support"). The latter mentions r8a73a4.dtsi but shdma support was
removed from that with commit cfda82037780 ("ARM: dts: r8a73a4: Remove
non-functional DMA support"), so it seems this is safe to remove.

Signed-off-by: Stephen Kitt <[email protected]>
---
drivers/dma/sh/shdma-arm.h | 48 --------------------------------------
1 file changed, 48 deletions(-)
delete mode 100644 drivers/dma/sh/shdma-arm.h

diff --git a/drivers/dma/sh/shdma-arm.h b/drivers/dma/sh/shdma-arm.h
deleted file mode 100644
index 7459f9a13b5b..000000000000
--- a/drivers/dma/sh/shdma-arm.h
+++ /dev/null
@@ -1,48 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-/*
- * Renesas SuperH DMA Engine support
- *
- * Copyright (C) 2013 Renesas Electronics, Inc.
- */
-
-#ifndef SHDMA_ARM_H
-#define SHDMA_ARM_H
-
-#include "shdma.h"
-
-/* Transmit sizes and respective CHCR register values */
-enum {
- XMIT_SZ_8BIT = 0,
- XMIT_SZ_16BIT = 1,
- XMIT_SZ_32BIT = 2,
- XMIT_SZ_64BIT = 7,
- XMIT_SZ_128BIT = 3,
- XMIT_SZ_256BIT = 4,
- XMIT_SZ_512BIT = 5,
-};
-
-/* log2(size / 8) - used to calculate number of transfers */
-#define SH_DMAE_TS_SHIFT { \
- [XMIT_SZ_8BIT] = 0, \
- [XMIT_SZ_16BIT] = 1, \
- [XMIT_SZ_32BIT] = 2, \
- [XMIT_SZ_64BIT] = 3, \
- [XMIT_SZ_128BIT] = 4, \
- [XMIT_SZ_256BIT] = 5, \
- [XMIT_SZ_512BIT] = 6, \
-}
-
-#define TS_LOW_BIT 0x3 /* --xx */
-#define TS_HI_BIT 0xc /* xx-- */
-
-#define TS_LOW_SHIFT (3)
-#define TS_HI_SHIFT (20 - 2) /* 2 bits for shifted low TS */
-
-#define TS_INDEX2VAL(i) \
- ((((i) & TS_LOW_BIT) << TS_LOW_SHIFT) |\
- (((i) & TS_HI_BIT) << TS_HI_SHIFT))
-
-#define CHCR_TX(xmit_sz) (DM_FIX | SM_INC | RS_ERS | TS_INDEX2VAL((xmit_sz)))
-#define CHCR_RX(xmit_sz) (DM_INC | SM_FIX | RS_ERS | TS_INDEX2VAL((xmit_sz)))
-
-#endif

base-commit: 23758867219c8d84c8363316e6dd2f9fd7ae3049
--
2.31.1



2022-10-28 13:17:35

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: sh: Remove unused shdma-arm.h

On Fri, Oct 28, 2022 at 1:54 PM Stephen Kitt <[email protected]> wrote:
> shdma-arm.h was introduced with commit 1e69653d40f1 ("DMA: shdma: add
> r8a73a4 DMAC data to the device ID table"), and its sole user was
> removed with commit a19788612f51 ("dmaengine: sh: Remove R-Mobile APE6
> support"). The latter mentions r8a73a4.dtsi but shdma support was
> removed from that with commit cfda82037780 ("ARM: dts: r8a73a4: Remove
> non-functional DMA support"), so it seems this is safe to remove.
>
> Signed-off-by: Stephen Kitt <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2022-11-04 15:18:44

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] dmaengine: sh: Remove unused shdma-arm.h

On 28-10-22, 13:53, Stephen Kitt wrote:
> shdma-arm.h was introduced with commit 1e69653d40f1 ("DMA: shdma: add
> r8a73a4 DMAC data to the device ID table"), and its sole user was
> removed with commit a19788612f51 ("dmaengine: sh: Remove R-Mobile APE6
> support"). The latter mentions r8a73a4.dtsi but shdma support was
> removed from that with commit cfda82037780 ("ARM: dts: r8a73a4: Remove
> non-functional DMA support"), so it seems this is safe to remove.

Applied, thanks

--
~Vinod