2022-10-29 10:35:26

by Shaomin Deng

[permalink] [raw]
Subject: [PATCH] mm/vmscan: delete rebundant word in comments

Delete the repeated word "that" in comments.

Signed-off-by: Shaomin Deng <[email protected]>
---
mm/vmscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 27a3f29c0181..2ad2fec6ed3f 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -7053,7 +7053,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)

/*
* There should be no need to raise the scanning priority if
- * enough pages are already being scanned that that high
+ * enough pages are already being scanned that high
* watermark would be met at 100% efficiency.
*/
if (kswapd_shrink_node(pgdat, &sc))
--
2.35.1



2022-10-29 13:07:18

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH] mm/vmscan: delete rebundant word in comments

On Sat, Oct 29, 2022 at 06:04:31AM -0400, Shaomin Deng wrote:
> Delete the repeated word "that" in comments.
>

Meh...

On what comment?

Also, on patch subject, s/rebundant/redundant/.

> Signed-off-by: Shaomin Deng <[email protected]>
> ---
> mm/vmscan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 27a3f29c0181..2ad2fec6ed3f 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -7053,7 +7053,7 @@ static int balance_pgdat(pg_data_t *pgdat, int order, int highest_zoneidx)

Ah! You mean balance_pgdat().

>
> /*
> * There should be no need to raise the scanning priority if
> - * enough pages are already being scanned that that high
> + * enough pages are already being scanned that high
> * watermark would be met at 100% efficiency.
> */
> if (kswapd_shrink_node(pgdat, &sc))

Dunno if the comment above is right.

I have already say to fellow @cdjrlc.com people that you and your team
**IGNORE** patch reviews. If you don't reply to this review, I would like
to just say NAK.

Thanks.

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (1.16 kB)
signature.asc (235.00 B)
Download all attachments

2022-10-29 16:09:54

by Matthew Wilcox

[permalink] [raw]
Subject: Re: [PATCH] mm/vmscan: delete rebundant word in comments

On Sat, Oct 29, 2022 at 06:04:31AM -0400, Shaomin Deng wrote:
> Delete the repeated word "that" in comments.

I think you've misunderstood the comment. NAK.