I got a warning using the latest mainline codes to start vms as following:
===================================================
WARNING: CPU: 1 PID: 1 at net/netlink/genetlink.c:383 genl_register_family+0x6c/0x76c
CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc2-00886-g882ad2a2a8ff #43
...
Call trace:
genl_register_family+0x6c/0x76c
dp_init+0xa8/0x124
do_one_initcall+0x84/0x450
It is because that commit 9c5d03d36251 ("genetlink: start to validate
reserved header bytes") has missed the resv_start_op initialization
for dp_vport_genl_family, and commit ce48ebdd5651 ("genetlink: limit
the use of validation workarounds to old ops") add checking warning.
Add resv_start_op initialization for dp_vport_genl_family to fix it.
Fixes: 9c5d03d36251 ("genetlink: start to validate reserved header bytes")
Signed-off-by: Ziyang Xuan <[email protected]>
---
net/openvswitch/datapath.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index 155263e73512..8b84869eb2ac 100644
--- a/net/openvswitch/datapath.c
+++ b/net/openvswitch/datapath.c
@@ -2544,6 +2544,7 @@ struct genl_family dp_vport_genl_family __ro_after_init = {
.parallel_ops = true,
.small_ops = dp_vport_genl_ops,
.n_small_ops = ARRAY_SIZE(dp_vport_genl_ops),
+ .resv_start_op = OVS_VPORT_CMD_SET + 1,
.mcgrps = &ovs_dp_vport_multicast_group,
.n_mcgrps = 1,
.module = THIS_MODULE,
--
2.25.1
On 10/31/22 09:12, Ziyang Xuan via dev wrote:
> I got a warning using the latest mainline codes to start vms as following:
>
> ===================================================
> WARNING: CPU: 1 PID: 1 at net/netlink/genetlink.c:383 genl_register_family+0x6c/0x76c
> CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc2-00886-g882ad2a2a8ff #43
> ...
> Call trace:
> genl_register_family+0x6c/0x76c
> dp_init+0xa8/0x124
> do_one_initcall+0x84/0x450
>
> It is because that commit 9c5d03d36251 ("genetlink: start to validate
> reserved header bytes") has missed the resv_start_op initialization
> for dp_vport_genl_family, and commit ce48ebdd5651 ("genetlink: limit
> the use of validation workarounds to old ops") add checking warning.
>
> Add resv_start_op initialization for dp_vport_genl_family to fix it.
>
> Fixes: 9c5d03d36251 ("genetlink: start to validate reserved header bytes")
> Signed-off-by: Ziyang Xuan <[email protected]>
> ---
Hi, Ziyang Xuan. Thanks for the patch!
But it looks like Jakub already fixed that issue a couple of days ago:
https://git.kernel.org/netdev/net/c/e4ba4554209f
Best regards, Ilya Maximets.
> On 10/31/22 09:12, Ziyang Xuan via dev wrote:
>> I got a warning using the latest mainline codes to start vms as following:
>>
>> ===================================================
>> WARNING: CPU: 1 PID: 1 at net/netlink/genetlink.c:383 genl_register_family+0x6c/0x76c
>> CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc2-00886-g882ad2a2a8ff #43
>> ...
>> Call trace:
>> genl_register_family+0x6c/0x76c
>> dp_init+0xa8/0x124
>> do_one_initcall+0x84/0x450
>>
>> It is because that commit 9c5d03d36251 ("genetlink: start to validate
>> reserved header bytes") has missed the resv_start_op initialization
>> for dp_vport_genl_family, and commit ce48ebdd5651 ("genetlink: limit
>> the use of validation workarounds to old ops") add checking warning.
>>
>> Add resv_start_op initialization for dp_vport_genl_family to fix it.
>>
>> Fixes: 9c5d03d36251 ("genetlink: start to validate reserved header bytes")
>> Signed-off-by: Ziyang Xuan <[email protected]>
>> ---
>
> Hi, Ziyang Xuan. Thanks for the patch!
>
> But it looks like Jakub already fixed that issue a couple of days ago:
> https://git.kernel.org/netdev/net/c/e4ba4554209f
>
That's fine. Ignore this.
Thank you.
> Best regards, Ilya Maximets.
>
> .
>
Hello:
This patch was applied to bpf/bpf.git (master)
by Jakub Kicinski <[email protected]>:
On Mon, 31 Oct 2022 16:12:10 +0800 you wrote:
> I got a warning using the latest mainline codes to start vms as following:
>
> ===================================================
> WARNING: CPU: 1 PID: 1 at net/netlink/genetlink.c:383 genl_register_family+0x6c/0x76c
> CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc2-00886-g882ad2a2a8ff #43
> ...
> Call trace:
> genl_register_family+0x6c/0x76c
> dp_init+0xa8/0x124
> do_one_initcall+0x84/0x450
>
> [...]
Here is the summary with links:
- [net] openvswitch: add missing resv_start_op initialization for dp_vport_genl_family
https://git.kernel.org/bpf/bpf/c/e4ba4554209f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html