2022-11-01 11:18:42

by Matthias Schiffer

Subject: [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code

Checking phandle references like mmc-pwrseq can result in -EPROBE_DEFER.

Signed-off-by: Matthias Schiffer <[email protected]>
---
drivers/mmc/host/sdhci_am654.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
index 8f1023480e12..4e17efa8ab97 100644
--- a/drivers/mmc/host/sdhci_am654.c
+++ b/drivers/mmc/host/sdhci_am654.c
@@ -835,7 +835,7 @@ static int sdhci_am654_probe(struct platform_device *pdev)

ret = mmc_of_parse(host->mmc);
if (ret) {
- dev_err(dev, "parsing dt failed (%d)\n", ret);
+ dev_err_probe(dev, ret, "parsing dt failed\n");
goto pm_runtime_put;
}

--
2.25.1

2022-11-02 11:33:48

by Adrian Hunter

Subject: Re: [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code

On 1/11/22 12:52, Matthias Schiffer wrote:
> Checking phandle references like mmc-pwrseq can result in -EPROBE_DEFER.
>
> Signed-off-by: Matthias Schiffer <[email protected]>

Acked-by: Adrian Hunter <[email protected]>

> ---
> drivers/mmc/host/sdhci_am654.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 8f1023480e12..4e17efa8ab97 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -835,7 +835,7 @@ static int sdhci_am654_probe(struct platform_device *pdev)
>
> ret = mmc_of_parse(host->mmc);
> if (ret) {
> - dev_err(dev, "parsing dt failed (%d)\n", ret);
> + dev_err_probe(dev, ret, "parsing dt failed\n");
> goto pm_runtime_put;
> }
>

2022-11-07 21:06:17

by Ulf Hansson

Subject: Re: [PATCH] mmc: sdhci_am654: Use dev_err_probe() for mmc_of_parse() return code

On Tue, 1 Nov 2022 at 11:53, Matthias Schiffer
<[email protected]> wrote:
>
> Checking phandle references like mmc-pwrseq can result in -EPROBE_DEFER.
>
> Signed-off-by: Matthias Schiffer <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/sdhci_am654.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 8f1023480e12..4e17efa8ab97 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -835,7 +835,7 @@ static int sdhci_am654_probe(struct platform_device *pdev)
>
> ret = mmc_of_parse(host->mmc);
> if (ret) {
> - dev_err(dev, "parsing dt failed (%d)\n", ret);
> + dev_err_probe(dev, ret, "parsing dt failed\n");
> goto pm_runtime_put;
> }
>
> --
> 2.25.1
>