2022-11-01 11:18:33

by jovial umwari

Subject: [RESEND PATCH v3] staging: most: dim2: hal: aligning function parameters

To improve readability, start the list of
function parameters on the same line as the function name.
Issue reported by checkpatch.

Signed-off-by: UMWARI JOVIAL <[email protected]>
---

Changes in v3:
1.Updated the commit message to well explain the changes made

drivers/staging/most/dim2/hal.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
index a5d40b5b138a..6abe3ab2b2cf 100644
--- a/drivers/staging/most/dim2/hal.c
+++ b/drivers/staging/most/dim2/hal.c
@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
dim2_clear_ctr(ctr_addr);
}

-static void dim2_configure_channel(
- u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
- u16 packet_length)
+static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
+ u16 hw_buffer_size, u16 packet_length)
{
dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
--
2.25.1

2022-11-01 18:23:25

by Greg Kroah-Hartman

Subject: Re: [RESEND PATCH v3] staging: most: dim2: hal: aligning function parameters

On Tue, Nov 01, 2022 at 01:57:27PM +0300, UMWARI JOVIAL wrote:
> To improve readability, start the list of
> function parameters on the same line as the function name.

Odd line-wrapping, please fix.

> Issue reported by checkpatch.
>
> Signed-off-by: UMWARI JOVIAL <[email protected]>
> ---
>
> Changes in v3:
> 1.Updated the commit message to well explain the changes made

What were the changes in v2?

Also, why do you have "RESEND" in the subject line? This is not a
resend of the v3 patch, it is the first time we have seen it.

thanks,

greg k-h