2022-11-01 16:49:13

by Jonathan Neuschäfer

[permalink] [raw]
Subject: [PATCH] mtd: spi-nor: Fix formatting in spi_nor_read_raw() kerneldoc comment

It doesn't make sense to put "set" on its own line like that.

Signed-off-by: Jonathan Neuschäfer <[email protected]>
---
drivers/mtd/spi-nor/sfdp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c
index 2257f1b4c2e2d..3e0bb383ab8e2 100644
--- a/drivers/mtd/spi-nor/sfdp.c
+++ b/drivers/mtd/spi-nor/sfdp.c
@@ -135,8 +135,7 @@ struct sfdp_4bait {
/**
* spi_nor_read_raw() - raw read of serial flash memory. read_opcode,
* addr_nbytes and read_dummy members of the struct spi_nor
- * should be previously
- * set.
+ * should be previously set.
* @nor: pointer to a 'struct spi_nor'
* @addr: offset in the serial flash memory
* @len: number of bytes to read
--
2.35.1



2022-11-06 23:26:02

by Pratyush Yadav

[permalink] [raw]
Subject: Re: [PATCH] mtd: spi-nor: Fix formatting in spi_nor_read_raw() kerneldoc comment

On 01/11/22 05:29PM, Jonathan Neusch?fer wrote:
> It doesn't make sense to put "set" on its own line like that.
>
> Signed-off-by: Jonathan Neusch?fer <[email protected]>

Acked-by: Pratyush Yadav <[email protected]>

> ---
> drivers/mtd/spi-nor/sfdp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c
> index 2257f1b4c2e2d..3e0bb383ab8e2 100644
> --- a/drivers/mtd/spi-nor/sfdp.c
> +++ b/drivers/mtd/spi-nor/sfdp.c
> @@ -135,8 +135,7 @@ struct sfdp_4bait {
> /**
> * spi_nor_read_raw() - raw read of serial flash memory. read_opcode,
> * addr_nbytes and read_dummy members of the struct spi_nor
> - * should be previously
> - * set.
> + * should be previously set.
> * @nor: pointer to a 'struct spi_nor'
> * @addr: offset in the serial flash memory
> * @len: number of bytes to read
> --
> 2.35.1
>

--
Regards,
Pratyush Yadav

2022-11-21 14:48:39

by Tudor Ambarus

[permalink] [raw]
Subject: Re: [PATCH] mtd: spi-nor: Fix formatting in spi_nor_read_raw() kerneldoc comment

On Tue, 1 Nov 2022 17:29:06 +0100, Jonathan Neuschäfer wrote:
> It doesn't make sense to put "set" on its own line like that.
>
>

Applied to spi-nor/next, thanks!

[1/1] mtd: spi-nor: Fix formatting in spi_nor_read_raw() kerneldoc comment
https://git.kernel.org/mtd/c/270450a1b6d8

Best regards,
--
Tudor Ambarus <[email protected]>