2022-11-02 09:25:48

by Robert Foss

[permalink] [raw]
Subject: [PATCH v2 0/5] dispcc-sm8250 misc fixes

Changes since v1:
- Added new a-b/r-b tags
- Improved commit message - Dmitry
- Configure dp/edp link parent_hw for sm8150/sc8180

Robert Foss (5):
clk: qcom: dispcc-sm8250: Disable EDP_GTC for sm8350
clk: qcom: dispcc-sm8250: Add RETAIN_FF_ENABLE flag for mdss_gdsc
dt-bindings: clock: dispcc-sm8250: Add EDP_LINK_DIV_CLK_SRC index
clk: qcom: dispcc-sm8250: Add missing EDP clocks for sm8350
clk: qcom: dispcc-sm8250: Disable link_div_clk_src for sm8150

drivers/clk/qcom/dispcc-sm8250.c | 38 ++++++++++++++++++-
.../dt-bindings/clock/qcom,dispcc-sm8250.h | 1 +
2 files changed, 37 insertions(+), 2 deletions(-)

--
2.34.1



2022-11-02 09:26:52

by Robert Foss

[permalink] [raw]
Subject: [PATCH v2 2/5] clk: qcom: dispcc-sm8250: Add RETAIN_FF_ENABLE flag for mdss_gdsc

All SoC supported by this driver supports the RETAIN_FF_ENABLE flag,
so it should be enabled here.

This feature enables registers to maintain their state after
dis/re-enabling the GDSC.

Signed-off-by: Robert Foss <[email protected]>
Reviewed-by: Dmitry Baryshkov <[email protected]>
Reviewed-by: Konrad Dybcio <[email protected]>
---
drivers/clk/qcom/dispcc-sm8250.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/dispcc-sm8250.c b/drivers/clk/qcom/dispcc-sm8250.c
index 180ac2726f7e..a7606580cf22 100644
--- a/drivers/clk/qcom/dispcc-sm8250.c
+++ b/drivers/clk/qcom/dispcc-sm8250.c
@@ -1137,7 +1137,7 @@ static struct gdsc mdss_gdsc = {
.name = "mdss_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
- .flags = HW_CTRL,
+ .flags = HW_CTRL | RETAIN_FF_ENABLE,
};

static struct clk_regmap *disp_cc_sm8250_clocks[] = {
--
2.34.1


2022-11-07 04:17:38

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] dispcc-sm8250 misc fixes

On Wed, 2 Nov 2022 10:01:35 +0100, Robert Foss wrote:
> Changes since v1:
> - Added new a-b/r-b tags
> - Improved commit message - Dmitry
> - Configure dp/edp link parent_hw for sm8150/sc8180
>
> Robert Foss (5):
> clk: qcom: dispcc-sm8250: Disable EDP_GTC for sm8350
> clk: qcom: dispcc-sm8250: Add RETAIN_FF_ENABLE flag for mdss_gdsc
> dt-bindings: clock: dispcc-sm8250: Add EDP_LINK_DIV_CLK_SRC index
> clk: qcom: dispcc-sm8250: Add missing EDP clocks for sm8350
> clk: qcom: dispcc-sm8250: Disable link_div_clk_src for sm8150
>
> [...]

Applied, thanks!

[1/5] clk: qcom: dispcc-sm8250: Disable EDP_GTC for sm8350
commit: b5f84650fb0d6ebaa48a5f99183de70d32d0b115
[2/5] clk: qcom: dispcc-sm8250: Add RETAIN_FF_ENABLE flag for mdss_gdsc
commit: e1a297a681bc4ab2c5cfe31eb4b59bb6f202035a
[3/5] dt-bindings: clock: dispcc-sm8250: Add EDP_LINK_DIV_CLK_SRC index
commit: c2b6ad72959771730806bbab76aa69e99444bf29
[4/5] clk: qcom: dispcc-sm8250: Add missing EDP clocks for sm8350
commit: 8305ff41c7426b49090b236da659e2e9bb05fcb9
[5/5] clk: qcom: dispcc-sm8250: Disable link_div_clk_src for sm8150
commit: f05dbd1a500661a9e3af59f0690301d031140da7

Best regards,
--
Bjorn Andersson <[email protected]>