2022-10-19 13:58:22

by Kory Maincent

Subject: [PATCH 6/6] clk: spear: Fix SSP clock definition on SPEAr600

From: Kory Maincent <[email protected]>

There is no SPEAr600 device named "ssp-pl022.x". Instead, the description
of the SSP (Synchronous Serial Port) was recently added to the Device Tree,
and the device name is "xxx.spi", so we should associate the SSP gateable
clock to these device names.

Signed-off-by: Kory Maincent <[email protected]>
---
drivers/clk/spear/spear6xx_clock.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/spear/spear6xx_clock.c b/drivers/clk/spear/spear6xx_clock.c
index ee0ed89f2954..adfa118520c3 100644
--- a/drivers/clk/spear/spear6xx_clock.c
+++ b/drivers/clk/spear/spear6xx_clock.c
@@ -326,13 +326,13 @@ void __init spear6xx_clk_init(void __iomem *misc_base)

clk = clk_register_gate(NULL, "ssp0_clk", "apb_clk", 0, PERIP1_CLK_ENB,
SSP0_CLK_ENB, 0, &_lock);
- clk_register_clkdev(clk, NULL, "ssp-pl022.0");
+ clk_register_clkdev(clk, NULL, "d0100000.spi");

clk = clk_register_gate(NULL, "ssp1_clk", "apb_clk", 0, PERIP1_CLK_ENB,
SSP1_CLK_ENB, 0, &_lock);
- clk_register_clkdev(clk, NULL, "ssp-pl022.1");
+ clk_register_clkdev(clk, NULL, "d0180000.spi");

clk = clk_register_gate(NULL, "ssp2_clk", "apb_clk", 0, PERIP1_CLK_ENB,
SSP2_CLK_ENB, 0, &_lock);
- clk_register_clkdev(clk, NULL, "ssp-pl022.2");
+ clk_register_clkdev(clk, NULL, "d8180000.spi");
}
--
2.25.1

2022-10-20 05:23:05

by Viresh Kumar

Subject: Re: [PATCH 6/6] clk: spear: Fix SSP clock definition on SPEAr600

On 19-10-22, 15:32, K?ry Maincent wrote:
> From: Kory Maincent <[email protected]>
>
> There is no SPEAr600 device named "ssp-pl022.x". Instead, the description
> of the SSP (Synchronous Serial Port) was recently added to the Device Tree,
> and the device name is "xxx.spi", so we should associate the SSP gateable
> clock to these device names.
>
> Signed-off-by: Kory Maincent <[email protected]>
> ---
> drivers/clk/spear/spear6xx_clock.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2022-11-02 08:47:22

by Kory Maincent

Subject: Re: [PATCH 6/6] clk: spear: Fix SSP clock definition on SPEAr600

Hello Stephen,

On Thu, 27 Oct 2022 17:22:17 -0700
Stephen Boyd <[email protected]> wrote:

> Quoting Köry Maincent (2022-10-19 06:32:08)
> > From: Kory Maincent <[email protected]>
> >
> > There is no SPEAr600 device named "ssp-pl022.x". Instead, the description
> > of the SSP (Synchronous Serial Port) was recently added to the Device Tree,
> > and the device name is "xxx.spi", so we should associate the SSP gateable
> > clock to these device names.
> >
> > Signed-off-by: Kory Maincent <[email protected]>
>
> Does this need a Fixes tag?

The old commits on SEAr6xx clock names definition update did not have it,
therefore I don't think so.

Regards,