2022-10-19 14:44:53

by Kory Maincent

Subject: [PATCH 4/6] clk: spear: Fix CLCD clock definition on SPEAr600

From: Kory Maincent <[email protected]>

There is no SPEAr600 device named "clcd". Instead, the description of the
CLCD (color liquid crystal display controller) name is "fc200000.clcd", so
we should associate the CLCD gateable clock to this device name.

Signed-off-by: Kory Maincent <[email protected]>
---
drivers/clk/spear/spear6xx_clock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/spear/spear6xx_clock.c b/drivers/clk/spear/spear6xx_clock.c
index c192a9141b86..ee0ed89f2954 100644
--- a/drivers/clk/spear/spear6xx_clock.c
+++ b/drivers/clk/spear/spear6xx_clock.c
@@ -207,7 +207,7 @@ void __init spear6xx_clk_init(void __iomem *misc_base)

clk = clk_register_gate(NULL, "clcd_clk", "clcd_mclk", 0,
PERIP1_CLK_ENB, CLCD_CLK_ENB, 0, &_lock);
- clk_register_clkdev(clk, NULL, "clcd");
+ clk_register_clkdev(clk, NULL, "fc200000.clcd");

/* gpt clocks */
clk = clk_register_gpt("gpt0_1_syn_clk", "pll1_clk", 0, PRSC0_CLK_CFG,
--
2.25.1

2022-10-20 04:41:19

by Viresh Kumar

Subject: Re: [PATCH 4/6] clk: spear: Fix CLCD clock definition on SPEAr600

On 19-10-22, 15:32, K?ry Maincent wrote:
> From: Kory Maincent <[email protected]>
>
> There is no SPEAr600 device named "clcd". Instead, the description of the
> CLCD (color liquid crystal display controller) name is "fc200000.clcd", so
> we should associate the CLCD gateable clock to this device name.
>
> Signed-off-by: Kory Maincent <[email protected]>
> ---
> drivers/clk/spear/spear6xx_clock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/spear/spear6xx_clock.c b/drivers/clk/spear/spear6xx_clock.c
> index c192a9141b86..ee0ed89f2954 100644
> --- a/drivers/clk/spear/spear6xx_clock.c
> +++ b/drivers/clk/spear/spear6xx_clock.c
> @@ -207,7 +207,7 @@ void __init spear6xx_clk_init(void __iomem *misc_base)
>
> clk = clk_register_gate(NULL, "clcd_clk", "clcd_mclk", 0,
> PERIP1_CLK_ENB, CLCD_CLK_ENB, 0, &_lock);
> - clk_register_clkdev(clk, NULL, "clcd");
> + clk_register_clkdev(clk, NULL, "fc200000.clcd");
>
> /* gpt clocks */
> clk = clk_register_gpt("gpt0_1_syn_clk", "pll1_clk", 0, PRSC0_CLK_CFG,

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2022-11-02 09:04:25

by Kory Maincent

Subject: Re: [PATCH 4/6] clk: spear: Fix CLCD clock definition on SPEAr600

Hello Stephan,

On Thu, 27 Oct 2022 17:21:47 -0700
Stephen Boyd <[email protected]> wrote:

> Quoting Köry Maincent (2022-10-19 06:32:06)
> > From: Kory Maincent <[email protected]>
> >
> > There is no SPEAr600 device named "clcd". Instead, the description of the
> > CLCD (color liquid crystal display controller) name is "fc200000.clcd", so
> > we should associate the CLCD gateable clock to this device name.
> >
> > Signed-off-by: Kory Maincent <[email protected]>
>
> Does this need a Fixes tag?

The old commits on SEAr6xx clock names definition update did not have it,
therefore I don't think so.

Regards,