From: Quentin Schulz <[email protected]>
The reset line is active low for the Goodix touchscreen controller so
let's fix the polarity in the Device Tree node.
Signed-off-by: Quentin Schulz <[email protected]>
---
arch/arm/boot/dts/imx6q-kp.dtsi | 2 +-
arch/arm/boot/dts/imx6ul-kontron-bl-43.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-kp.dtsi b/arch/arm/boot/dts/imx6q-kp.dtsi
index 1ade0bff681d6..dae14aaf803a8 100644
--- a/arch/arm/boot/dts/imx6q-kp.dtsi
+++ b/arch/arm/boot/dts/imx6q-kp.dtsi
@@ -188,7 +188,7 @@ touchscreen@5d {
interrupt-parent = <&gpio1>;
interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
irq-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>;
- reset-gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpio5 2 GPIO_ACTIVE_LOW>;
};
ds1307: rtc@32 {
diff --git a/arch/arm/boot/dts/imx6ul-kontron-bl-43.dts b/arch/arm/boot/dts/imx6ul-kontron-bl-43.dts
index 0c643706a158b..767ef5da76136 100644
--- a/arch/arm/boot/dts/imx6ul-kontron-bl-43.dts
+++ b/arch/arm/boot/dts/imx6ul-kontron-bl-43.dts
@@ -29,7 +29,7 @@ touchscreen@5d {
pinctrl-0 = <&pinctrl_cap_touch>;
interrupt-parent = <&gpio5>;
interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
- reset-gpios = <&gpio5 8 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
irq-gpios = <&gpio5 6 GPIO_ACTIVE_HIGH>;
};
};
--
b4 0.10.1
On 05.12.22 14:40, Quentin Schulz wrote:
> From: Quentin Schulz <[email protected]>
>
> The reset line is active low for the Goodix touchscreen controller so
> let's fix the polarity in the Device Tree node.
>
> Signed-off-by: Quentin Schulz <[email protected]>
> ---
> arch/arm/boot/dts/imx6q-kp.dtsi | 2 +-
> arch/arm/boot/dts/imx6ul-kontron-bl-43.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6q-kp.dtsi b/arch/arm/boot/dts/imx6q-kp.dtsi
> index 1ade0bff681d6..dae14aaf803a8 100644
> --- a/arch/arm/boot/dts/imx6q-kp.dtsi
> +++ b/arch/arm/boot/dts/imx6q-kp.dtsi
> @@ -188,7 +188,7 @@ touchscreen@5d {
> interrupt-parent = <&gpio1>;
> interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> irq-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>;
> - reset-gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio5 2 GPIO_ACTIVE_LOW>;
> };
>
> ds1307: rtc@32 {
> diff --git a/arch/arm/boot/dts/imx6ul-kontron-bl-43.dts b/arch/arm/boot/dts/imx6ul-kontron-bl-43.dts
> index 0c643706a158b..767ef5da76136 100644
> --- a/arch/arm/boot/dts/imx6ul-kontron-bl-43.dts
> +++ b/arch/arm/boot/dts/imx6ul-kontron-bl-43.dts
> @@ -29,7 +29,7 @@ touchscreen@5d {
> pinctrl-0 = <&pinctrl_cap_touch>;
> interrupt-parent = <&gpio5>;
> interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
> - reset-gpios = <&gpio5 8 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
> irq-gpios = <&gpio5 6 GPIO_ACTIVE_HIGH>;
> };
> };
The imx6ul-kontron-bl-43.dts misses a working panel node, so I'm pretty
sure it is not used and nobody will bother about change breaking
compatibility. I don't have the hardware at hand at the moment to
perform a test, so for now:
Acked-by: Frieder Schrempf <[email protected]> #
imx6ul-kontron-bl-43.dts
On Tue, 6 Dec 2022 12:25:29 +0100
Frieder Schrempf <[email protected]> wrote:
> On 05.12.22 14:40, Quentin Schulz wrote:
> > From: Quentin Schulz <[email protected]>
> >
> > The reset line is active low for the Goodix touchscreen controller
> > so let's fix the polarity in the Device Tree node.
> >
> > Signed-off-by: Quentin Schulz <[email protected]>
> > ---
> > arch/arm/boot/dts/imx6q-kp.dtsi | 2 +-
> > arch/arm/boot/dts/imx6ul-kontron-bl-43.dts | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6q-kp.dtsi
> > b/arch/arm/boot/dts/imx6q-kp.dtsi index
> > 1ade0bff681d6..dae14aaf803a8 100644 ---
> > a/arch/arm/boot/dts/imx6q-kp.dtsi +++
> > b/arch/arm/boot/dts/imx6q-kp.dtsi @@ -188,7 +188,7 @@
> > touchscreen@5d { interrupt-parent = <&gpio1>;
> > interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
> > irq-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>;
> > - reset-gpios = <&gpio5 2 GPIO_ACTIVE_HIGH>;
> > + reset-gpios = <&gpio5 2 GPIO_ACTIVE_LOW>;
> > };
> >
> > ds1307: rtc@32 {
> > diff --git a/arch/arm/boot/dts/imx6ul-kontron-bl-43.dts
> > b/arch/arm/boot/dts/imx6ul-kontron-bl-43.dts index
> > 0c643706a158b..767ef5da76136 100644 ---
> > a/arch/arm/boot/dts/imx6ul-kontron-bl-43.dts +++
> > b/arch/arm/boot/dts/imx6ul-kontron-bl-43.dts @@ -29,7 +29,7 @@
> > touchscreen@5d { pinctrl-0 = <&pinctrl_cap_touch>;
> > interrupt-parent = <&gpio5>;
> > interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
> > - reset-gpios = <&gpio5 8 GPIO_ACTIVE_HIGH>;
> > + reset-gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
> > irq-gpios = <&gpio5 6 GPIO_ACTIVE_HIGH>;
> > };
> > };
>
> The imx6ul-kontron-bl-43.dts misses a working panel node, so I'm
> pretty sure it is not used and nobody will bother about change
> breaking compatibility. I don't have the hardware at hand at the
> moment to perform a test, so for now:
>
> Acked-by: Frieder Schrempf <[email protected]> #
> imx6ul-kontron-bl-43.dts
Reviewed-by: Lukasz Majewski <[email protected]>
For imx6 TPC70 device.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]