2022-11-03 02:50:43

by chen zhang

Subject: [PATCH v3] platform/x86: ISST: Fix typo in comments

Fix spelling typo in comments.

Reported-by: k2ci <[email protected]>
Signed-off-by: chen zhang <[email protected]>
---
v3: Change "interace" to "interfaces", Change "share" to "shared"
Thanks for your advice.
v2: update the comments
There is a bug with my company's mailbox with kylinos.cn, and sometimes
I can't receive reply emails. I cc my personal 163 mailbox, so that I can
receive feedback from reviewer on time.
---
drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
index fd102678c75f..a7e02b24a87a 100644
--- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
+++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
@@ -623,7 +623,7 @@ static long isst_if_def_ioctl(struct file *file, unsigned int cmd,

/* Lock to prevent module registration when already opened by user space */
static DEFINE_MUTEX(punit_misc_dev_open_lock);
-/* Lock to allow one share misc device for all ISST interace */
+/* Lock to allow one shared misc device for all ISST interfaces */
static DEFINE_MUTEX(punit_misc_dev_reg_lock);
static int misc_usage_count;
static int misc_device_ret;
--
2.25.1

2022-11-07 15:36:53

by Hans de Goede

Subject: Re: [PATCH v3] platform/x86: ISST: Fix typo in comments

Hi,

On 11/3/22 02:33, chen zhang wrote:
> Fix spelling typo in comments.
>
> Reported-by: k2ci <[email protected]>
> Signed-off-by: chen zhang <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
> v3: Change "interace" to "interfaces", Change "share" to "shared"
> Thanks for your advice.
> v2: update the comments
> There is a bug with my company's mailbox with kylinos.cn, and sometimes
> I can't receive reply emails. I cc my personal 163 mailbox, so that I can
> receive feedback from reviewer on time.
> ---
> drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> index fd102678c75f..a7e02b24a87a 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> @@ -623,7 +623,7 @@ static long isst_if_def_ioctl(struct file *file, unsigned int cmd,
>
> /* Lock to prevent module registration when already opened by user space */
> static DEFINE_MUTEX(punit_misc_dev_open_lock);
> -/* Lock to allow one share misc device for all ISST interace */
> +/* Lock to allow one shared misc device for all ISST interfaces */
> static DEFINE_MUTEX(punit_misc_dev_reg_lock);
> static int misc_usage_count;
> static int misc_device_ret;