2022-11-03 06:20:44

by Keoseong Park

Subject: [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h

Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate
device initialization") added check_upiu_size(), but no caller.

Cc: Dolev Raviv <[email protected]>
Signed-off-by: Keoseong Park <[email protected]>
---
include/ufs/ufshcd.h | 6 ------
1 file changed, 6 deletions(-)

diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
index 96538eb3a6c0..5cf81dff60aa 100644
--- a/include/ufs/ufshcd.h
+++ b/include/ufs/ufshcd.h
@@ -1072,12 +1072,6 @@ void ufshcd_update_evt_hist(struct ufs_hba *hba, u32 id, u32 val);
void ufshcd_hba_stop(struct ufs_hba *hba);
void ufshcd_schedule_eh_work(struct ufs_hba *hba);

-static inline void check_upiu_size(void)
-{
- BUILD_BUG_ON(ALIGNED_UPIU_SIZE <
- GENERAL_UPIU_REQUEST_SIZE + QUERY_DESC_MAX_SIZE);
-}
-
/**
* ufshcd_set_variant - set variant specific data to the hba
* @hba: per adapter instance
--
2.17.1

2022-11-03 07:29:34

by Avri Altman

Subject: RE: [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h

> Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate device
> initialization") added check_upiu_size(), but no caller.
Nor there ever was.

>
> Cc: Dolev Raviv <[email protected]>
> Signed-off-by: Keoseong Park <[email protected]>
Reviewed-by: Avri Altman <[email protected]>

> ---
> include/ufs/ufshcd.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h index
> 96538eb3a6c0..5cf81dff60aa 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -1072,12 +1072,6 @@ void ufshcd_update_evt_hist(struct ufs_hba *hba,
> u32 id, u32 val); void ufshcd_hba_stop(struct ufs_hba *hba); void
> ufshcd_schedule_eh_work(struct ufs_hba *hba);
>
> -static inline void check_upiu_size(void) -{
> - BUILD_BUG_ON(ALIGNED_UPIU_SIZE <
> - GENERAL_UPIU_REQUEST_SIZE + QUERY_DESC_MAX_SIZE);
> -}
> -
> /**
> * ufshcd_set_variant - set variant specific data to the hba
> * @hba: per adapter instance
> --
> 2.17.1

2022-11-08 03:58:18

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h

Keoseong,

> Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate
> device initialization") added check_upiu_size(), but no caller.

Applied to 6.2/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2022-11-17 19:08:26

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs: Remove check_upiu_size() from ufshcd.h

On Thu, 03 Nov 2022 14:53:49 +0900, Keoseong Park wrote:

> Commit 68078d5cc1a5 ("[SCSI] ufs: Set fDeviceInit flag to initiate
> device initialization") added check_upiu_size(), but no caller.
>
>

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: ufs: Remove check_upiu_size() from ufshcd.h
https://git.kernel.org/mkp/scsi/c/3d6d7930928a

--
Martin K. Petersen Oracle Linux Engineering