2022-11-03 13:19:06

by Cosmin Tanislav

Subject: [PATCH v4 07/13] dt-bindings: iio: temperature: ltc2983: require 4 wire rtd for current rotate

From: Cosmin Tanislav <[email protected]>

The driver will error out when current rotation is enabled but the RTD
is not 4-wire. Require it in the binding too.

Signed-off-by: Cosmin Tanislav <[email protected]>
---
.../bindings/iio/temperature/adi,ltc2983.yaml | 25 +++++++++++--------
1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
index bbac5f5cfbb3..b603219fb0c9 100644
--- a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
+++ b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
@@ -230,13 +230,6 @@ patternProperties:
resistor is used for multiple 2-, 3-, and/or 4-wire RTDs.
type: boolean

- adi,current-rotate:
- description:
- Boolean property which enables excitation current rotation to
- automatically remove parasitic thermocouple effects. Note that
- this property is not allowed for 2- and 3-wire RTDs.
- type: boolean
-
adi,excitation-current-microamp:
description:
This property controls the magnitude of the excitation current
@@ -269,10 +262,22 @@ patternProperties:
required:
- adi,rsense-handle

- dependencies:
- adi,current-rotate: [ "adi,rsense-share" ]
-
allOf:
+ - if:
+ properties:
+ adi,number-of-wires:
+ const: 4
+ then:
+ properties:
+ adi,current-rotate:
+ description:
+ Whether to enable excitation current rotation to automatically
+ remove parasitic thermocouple effects.
+ type: boolean
+
+ dependencies:
+ adi,current-rotate: [ "adi,rsense-share" ]
+
- if:
properties:
adi,sensor-type:
--
2.38.1

2022-11-07 17:48:46

by Rob Herring

Subject: Re: [PATCH v4 07/13] dt-bindings: iio: temperature: ltc2983: require 4 wire rtd for current rotate

On Thu, 03 Nov 2022 15:00:35 +0200, Cosmin Tanislav wrote:
> From: Cosmin Tanislav <[email protected]>
>
> The driver will error out when current rotation is enabled but the RTD
> is not 4-wire. Require it in the binding too.
>
> Signed-off-by: Cosmin Tanislav <[email protected]>
> ---
> .../bindings/iio/temperature/adi,ltc2983.yaml | 25 +++++++++++--------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>