2022-11-03 16:10:27

by Yu, Richard

Subject: [PATCH v1 4/7] dt-bindings: usb: hpe,gxp-vuhc: add binding for gxp vEHCI

From: Richard Yu <[email protected]>

Create documentation for the hpe,gxp-vuhc binding to support access to
the gxp virtual EHCI controller.

Signed-off-by: Richard Yu <[email protected]>
---
.../devicetree/bindings/usb/hpe,gxp-vuhc.yaml | 34 +++++++++++++++++++
1 file changed, 34 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/hpe,gxp-vuhc.yaml

diff --git a/Documentation/devicetree/bindings/usb/hpe,gxp-vuhc.yaml b/Documentation/devicetree/bindings/usb/hpe,gxp-vuhc.yaml
new file mode 100644
index 000000000000..1411a2550092
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/hpe,gxp-vuhc.yaml
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/hpe,gxp-vuhc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: HPE GXP Virtual Universal Host Controller (vUHC)
+
+maintainers:
+ - Richard Yu <[email protected]>
+ - Jean-Marie Verdun <[email protected]>
+ - Nick Hawkins <[email protected]>
+
+properties:
+ compatible:
+ items:
+ - const: hpe,gxp-vuhc
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ vuhc@80400000 {
+ compatible = "hpe,gxp-vuhc", "syscon";
+ reg = <0x80400000 0x80>;
+ };
--
2.17.1

2022-11-03 16:48:42

by Krzysztof Kozlowski

Subject: Re: [PATCH v1 4/7] dt-bindings: usb: hpe,gxp-vuhc: add binding for gxp vEHCI

On 03/11/2022 12:06, [email protected] wrote:
> From: Richard Yu <[email protected]>
>
> Create documentation for the hpe,gxp-vuhc binding to support access to
> the gxp virtual EHCI controller.
>

Previous comments apply.

> Signed-off-by: Richard Yu <[email protected]>
> ---
> .../devicetree/bindings/usb/hpe,gxp-vuhc.yaml | 34 +++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/hpe,gxp-vuhc.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/hpe,gxp-vuhc.yaml b/Documentation/devicetree/bindings/usb/hpe,gxp-vuhc.yaml
> new file mode 100644
> index 000000000000..1411a2550092
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/hpe,gxp-vuhc.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/hpe,gxp-vuhc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HPE GXP Virtual Universal Host Controller (vUHC)

This is getting confusing.

If it is EHCI, you miss usb-hcd.yaml reference. But in fact you describe
at syscon, maybe to avoid proper hardware description.

That does not look right.

> +
> +maintainers:
> + - Richard Yu <[email protected]>
> + - Jean-Marie Verdun <[email protected]>
> + - Nick Hawkins <[email protected]>
> +
> +properties:
> + compatible:
> + items:
> + - const: hpe,gxp-vuhc
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + vuhc@80400000 {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> + compatible = "hpe,gxp-vuhc", "syscon";
> + reg = <0x80400000 0x80>;
> + };

Best regards,
Krzysztof