2022-11-04 03:12:19

by Deming Wang

Subject: [PATCH] zsmalloc: replace IS_ERR() with IS_ERR_VALUE()

Avoid typecasts that are needed for IS_ERR() and use IS_ERR_VALUE()
instead.

Signed-off-by: Deming Wang <[email protected]>
---
mm/zsmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index a40c548520d3..1322f3615067 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -379,7 +379,7 @@ static int zs_zpool_malloc(void *pool, size_t size, gfp_t gfp,
{
*handle = zs_malloc(pool, size, gfp);

- if (IS_ERR((void *)(*handle)))
+ if (IS_ERR_VALUE(*handle))
return PTR_ERR((void *)*handle);
return 0;
}
--
2.27.0

2022-11-04 03:26:28

by Sergey Senozhatsky

Subject: Re: [PATCH] zsmalloc: replace IS_ERR() with IS_ERR_VALUE()

On (22/11/03 22:38), Deming Wang wrote:
> Avoid typecasts that are needed for IS_ERR() and use IS_ERR_VALUE()
> instead.
>
> Signed-off-by: Deming Wang <[email protected]>

Reviewed-by: Sergey Senozhatsky <[email protected]>