The SM8250 AON Clock Controller compatible used by Linux driver and DTS
is qcom,sm8250-lpass-aoncc.
Fixes: 7dbe5a7a3f99 ("dt-bindings: clock: Add support for LPASS Always ON Controller")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/clock/qcom,aoncc-sm8250.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,aoncc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,aoncc-sm8250.yaml
index c40a74b5d672..59b0d3f571ef 100644
--- a/Documentation/devicetree/bindings/clock/qcom,aoncc-sm8250.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,aoncc-sm8250.yaml
@@ -17,7 +17,7 @@ description: |
properties:
compatible:
- const: qcom,sm8250-lpass-aon
+ const: qcom,sm8250-lpass-aoncc
reg:
maxItems: 1
@@ -50,7 +50,7 @@ examples:
#include <dt-bindings/sound/qcom,q6afe.h>
clock-controller@3800000 {
#clock-cells = <1>;
- compatible = "qcom,sm8250-lpass-aon";
+ compatible = "qcom,sm8250-lpass-aoncc";
reg = <0x03380000 0x40000>;
clocks = <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
<&q6afecc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
--
2.34.1
The SM8250 DTS uses three clocks as input to LPASS AudioClock Controller
(althopugh Linux driver seems not needing it), so document the missing
audio voting clock.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/clock/qcom,audiocc-sm8250.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,audiocc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,audiocc-sm8250.yaml
index 915d76206ad0..48c7e10cc1b9 100644
--- a/Documentation/devicetree/bindings/clock/qcom,audiocc-sm8250.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,audiocc-sm8250.yaml
@@ -28,11 +28,13 @@ properties:
clocks:
items:
- description: LPASS Core voting clock
+ - description: LPASS Audio codec voting clock
- description: Glitch Free Mux register clock
clock-names:
items:
- const: core
+ - const: audio
- const: bus
required:
@@ -53,6 +55,7 @@ examples:
compatible = "qcom,sm8250-lpass-audiocc";
reg = <0x03300000 0x30000>;
clocks = <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
<&q6afecc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
- clock-names = "core", "bus";
+ clock-names = "core", "audio", "bus";
};
--
2.34.1
The SM8250 DTS uses three clocks as input to LPASS AON Clock Controller
(althopugh Linux driver seems not needing it), so document the missing
audio voting clock.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/clock/qcom,aoncc-sm8250.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/qcom,aoncc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,aoncc-sm8250.yaml
index 59b0d3f571ef..7f24f640d102 100644
--- a/Documentation/devicetree/bindings/clock/qcom,aoncc-sm8250.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,aoncc-sm8250.yaml
@@ -28,11 +28,13 @@ properties:
clocks:
items:
- description: LPASS Core voting clock
+ - description: LPASS Audio codec voting clock
- description: Glitch Free Mux register clock
clock-names:
items:
- const: core
+ - const: audio
- const: bus
required:
@@ -53,6 +55,7 @@ examples:
compatible = "qcom,sm8250-lpass-aoncc";
reg = <0x03380000 0x40000>;
clocks = <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
<&q6afecc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
- clock-names = "core", "bus";
+ clock-names = "core", "audio", "bus";
};
--
2.34.1
Quoting Krzysztof Kozlowski (2022-11-04 10:46:54)
> The SM8250 AON Clock Controller compatible used by Linux driver and DTS
> is qcom,sm8250-lpass-aoncc.
>
> Fixes: 7dbe5a7a3f99 ("dt-bindings: clock: Add support for LPASS Always ON Controller")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
Quoting Krzysztof Kozlowski (2022-11-04 10:46:56)
> The SM8250 DTS uses three clocks as input to LPASS AudioClock Controller
> (althopugh Linux driver seems not needing it), so document the missing
> audio voting clock.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
Quoting Krzysztof Kozlowski (2022-11-04 10:46:55)
> The SM8250 DTS uses three clocks as input to LPASS AON Clock Controller
> (althopugh Linux driver seems not needing it), so document the missing
> audio voting clock.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Stephen Boyd <[email protected]>
On Fri, 4 Nov 2022 13:46:54 -0400, Krzysztof Kozlowski wrote:
> The SM8250 AON Clock Controller compatible used by Linux driver and DTS
> is qcom,sm8250-lpass-aoncc.
>
>
Applied, thanks!
[1/3] dt-bindings: clock: qcom,aoncc-sm8250: fix compatible
commit: 42f520f94e1644da423d3d2981be98beda3c4253
[2/3] dt-bindings: clock: qcom,aoncc-sm8250: add missing audio clock
commit: 850c156fa64f1b23954563ab6614d76e5a6d6af6
[3/3] dt-bindings: clock: qcom,audiocc-sm8250: add missing audio clock
commit: 618c01c3b2a95ea1e8ef25a005229cb78da64481
Best regards,
--
Bjorn Andersson <[email protected]>