2022-11-04 22:16:23

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: [PATCH 1/2] ASoC: mediatek: mt8183-da7219: Register to module device table

Register the compatibles for this module on the module device table so
it can be automatically loaded when a matching device is found on the
system.

Signed-off-by: Nícolas F. R. A. Prado <[email protected]>

---

sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c b/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
index 9f22d3939818..0e572fe28c58 100644
--- a/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
+++ b/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
@@ -842,6 +842,7 @@ static const struct of_device_id mt8183_da7219_max98357_dt_match[] = {
},
{}
};
+MODULE_DEVICE_TABLE(of, mt8183_da7219_max98357_dt_match);
#endif

static struct platform_driver mt8183_da7219_max98357_driver = {
--
2.38.1



Subject: Re: [PATCH 1/2] ASoC: mediatek: mt8183-da7219: Register to module device table

Il 04/11/22 22:24, Nícolas F. R. A. Prado ha scritto:
> Register the compatibles for this module on the module device table so
> it can be automatically loaded when a matching device is found on the
> system.
>
> Signed-off-by: Nícolas F. R. A. Prado <[email protected]>
>

Hello Nícolas,
I agree but.... can you please do the same for 8192, 8195, 8186?

Getting them all in one series would make absolute sense... :-)

in the meanwhile, for this one:

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

> ---
>
> sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c b/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
> index 9f22d3939818..0e572fe28c58 100644
> --- a/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
> +++ b/sound/soc/mediatek/mt8183/mt8183-da7219-max98357.c
> @@ -842,6 +842,7 @@ static const struct of_device_id mt8183_da7219_max98357_dt_match[] = {
> },
> {}
> };
> +MODULE_DEVICE_TABLE(of, mt8183_da7219_max98357_dt_match);
> #endif
>
> static struct platform_driver mt8183_da7219_max98357_driver = {



2022-11-07 16:06:36

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: Re: [PATCH 1/2] ASoC: mediatek: mt8183-da7219: Register to module device table

On Mon, Nov 07, 2022 at 10:06:51AM +0100, AngeloGioacchino Del Regno wrote:
> Il 04/11/22 22:24, N?colas F. R. A. Prado ha scritto:
> > Register the compatibles for this module on the module device table so
> > it can be automatically loaded when a matching device is found on the
> > system.
> >
> > Signed-off-by: N?colas F. R. A. Prado <[email protected]>
> >
>
> Hello N?colas,
> I agree but.... can you please do the same for 8192, 8195, 8186?
>
> Getting them all in one series would make absolute sense... :-)

Yes, I was planning to do that in a following series, to avoid extra churn on
all SoCs in case some change was needed. But perhaps I was being too careful, I
can add them here for v2.

Thanks,
N?colas