2022-11-05 14:34:01

by Kang Minchul

Subject: [PATCH] perf print-events: Remove redundant comparison with zero

Since variable npmus is unsigned int, comparing with 0 is unnecessary.

Signed-off-by: Kang Minchul <[email protected]>
---
tools/perf/util/print-events.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/perf/util/print-events.c b/tools/perf/util/print-events.c
index c4d5d87fae2f..6df947df1c0f 100644
--- a/tools/perf/util/print-events.c
+++ b/tools/perf/util/print-events.c
@@ -311,10 +311,8 @@ int print_hwcache_events(const char *event_glob, bool name_only)
if ((hybrid_supported == 0) ||
(hybrid_supported == npmus)) {
evt_list[evt_i] = strdup(name);
- if (npmus > 0) {
- for (j = 0; j < npmus; j++)
- zfree(&evt_pmus[j]);
- }
+ for (j = 0; j < npmus; j++)
+ zfree(&evt_pmus[j]);
} else {
for (j = 0; j < hybrid_supported; j++) {
evt_list[evt_i++] = evt_pmus[j];
--
2.34.1

2022-11-07 21:42:51

by Namhyung Kim

Subject: Re: [PATCH] perf print-events: Remove redundant comparison with zero

Hi Minchul,

On Sat, Nov 5, 2022 at 6:59 AM Kang Minchul <[email protected]> wrote:
>
> Since variable npmus is unsigned int, comparing with 0 is unnecessary.
>
> Signed-off-by: Kang Minchul <[email protected]>
> ---
> tools/perf/util/print-events.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/util/print-events.c b/tools/perf/util/print-events.c
> index c4d5d87fae2f..6df947df1c0f 100644
> --- a/tools/perf/util/print-events.c
> +++ b/tools/perf/util/print-events.c
> @@ -311,10 +311,8 @@ int print_hwcache_events(const char *event_glob, bool name_only)
> if ((hybrid_supported == 0) ||
> (hybrid_supported == npmus)) {
> evt_list[evt_i] = strdup(name);
> - if (npmus > 0) {
> - for (j = 0; j < npmus; j++)
> - zfree(&evt_pmus[j]);
> - }
> + for (j = 0; j < npmus; j++)
> + zfree(&evt_pmus[j]);

You can still have 0 npmus, but then the for loop will not be executed. So,

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung


> } else {
> for (j = 0; j < hybrid_supported; j++) {
> evt_list[evt_i++] = evt_pmus[j];
> --
> 2.34.1
>