2022-11-05 18:44:42

by Kang Minchul

Subject: [PATCH v3] selftests/bpf: Fix u32 variable compared with less than zero

Variable ret is compared with less than zero even though it was set as u32.
So u32 to int conversion is needed.

Signed-off-by: Kang Minchul <[email protected]>
---
tools/testing/selftests/bpf/xskxceiver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c
index 681a5db80dae..162d3a516f2c 100644
--- a/tools/testing/selftests/bpf/xskxceiver.c
+++ b/tools/testing/selftests/bpf/xskxceiver.c
@@ -1006,7 +1006,8 @@ static int __send_pkts(struct ifobject *ifobject, u32 *pkt_nb, struct pollfd *fd
{
struct xsk_socket_info *xsk = ifobject->xsk;
bool use_poll = ifobject->use_poll;
- u32 i, idx = 0, ret, valid_pkts = 0;
+ u32 i, idx = 0, valid_pkts = 0;
+ int ret;

while (xsk_ring_prod__reserve(&xsk->tx, BATCH_SIZE, &idx) < BATCH_SIZE) {
if (use_poll) {
--
2.34.1

2022-11-05 19:01:13

by Randy Dunlap

Subject: Re: [PATCH v3] selftests/bpf: Fix u32 variable compared with less than zero

On 11/5/22 11:36, Kang Minchul wrote:
> Variable ret is compared with less than zero even though it was set as u32.
> So u32 to int conversion is needed.
>
> Signed-off-by: Kang Minchul <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> tools/testing/selftests/bpf/xskxceiver.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c
> index 681a5db80dae..162d3a516f2c 100644
> --- a/tools/testing/selftests/bpf/xskxceiver.c
> +++ b/tools/testing/selftests/bpf/xskxceiver.c
> @@ -1006,7 +1006,8 @@ static int __send_pkts(struct ifobject *ifobject, u32 *pkt_nb, struct pollfd *fd
> {
> struct xsk_socket_info *xsk = ifobject->xsk;
> bool use_poll = ifobject->use_poll;
> - u32 i, idx = 0, ret, valid_pkts = 0;
> + u32 i, idx = 0, valid_pkts = 0;
> + int ret;
>
> while (xsk_ring_prod__reserve(&xsk->tx, BATCH_SIZE, &idx) < BATCH_SIZE) {
> if (use_poll) {

2022-11-06 12:50:19

by Björn Töpel

Subject: Re: [PATCH v3] selftests/bpf: Fix u32 variable compared with less than zero

Kang Minchul <[email protected]> writes:

> Variable ret is compared with less than zero even though it was set as u32.
> So u32 to int conversion is needed.
>
> Signed-off-by: Kang Minchul <[email protected]>

Acked-by: Björn Töpel <[email protected]>

2022-11-08 01:18:10

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v3] selftests/bpf: Fix u32 variable compared with less than zero

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <[email protected]>:

On Sun, 6 Nov 2022 03:36:56 +0900 you wrote:
> Variable ret is compared with less than zero even though it was set as u32.
> So u32 to int conversion is needed.
>
> Signed-off-by: Kang Minchul <[email protected]>
> ---
> tools/testing/selftests/bpf/xskxceiver.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Here is the summary with links:
- [v3] selftests/bpf: Fix u32 variable compared with less than zero
https://git.kernel.org/bpf/bpf-next/c/e8f50c4f0c14

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html