2022-11-06 17:21:35

by Chen-Yu Tsai

Subject: [PATCH] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt

From: Chen-Yu Tsai <[email protected]>

Ths PMIC's interrupt line is tied to GPIO0_A3. This is described
correctly for the pinmux setting, but incorrectly for the interrupt.

Correct the interrupt setting so that interrupts from the PMIC get
delivered.

Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
Signed-off-by: Chen-Yu Tsai <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
index 77b179cd20e7..b276eb0810c7 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
@@ -246,7 +246,7 @@ rk809: pmic@20 {
compatible = "rockchip,rk809";
reg = <0x20>;
interrupt-parent = <&gpio0>;
- interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
+ interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
clock-names = "mclk";
--
2.34.1

2022-11-07 01:21:47

by Peter Geis

Subject: Re: [PATCH] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt

On Sun, Nov 6, 2022 at 11:15 AM Chen-Yu Tsai <[email protected]> wrote:
>
> From: Chen-Yu Tsai <[email protected]>
>
> Ths PMIC's interrupt line is tied to GPIO0_A3. This is described
> correctly for the pinmux setting, but incorrectly for the interrupt.
>
> Correct the interrupt setting so that interrupts from the PMIC get
> delivered.
>
> Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
> Signed-off-by: Chen-Yu Tsai <[email protected]>

Good catch, thanks!
Reviewed-by: Peter Geis <[email protected]>

> ---
> arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> index 77b179cd20e7..b276eb0810c7 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> @@ -246,7 +246,7 @@ rk809: pmic@20 {
> compatible = "rockchip,rk809";
> reg = <0x20>;
> interrupt-parent = <&gpio0>;
> - interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
> + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
> assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
> assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
> clock-names = "mclk";
> --
> 2.34.1
>
>
> _______________________________________________
> Linux-rockchip mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

2022-11-15 11:33:42

by Heiko Stübner

Subject: Re: [PATCH] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt

On Mon, 7 Nov 2022 00:15:13 +0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <[email protected]>
>
> Ths PMIC's interrupt line is tied to GPIO0_A3. This is described
> correctly for the pinmux setting, but incorrectly for the interrupt.
>
> Correct the interrupt setting so that interrupts from the PMIC get
> delivered.
>
> [...]

Applied, thanks!

[1/1] arm64: dts: rockchip: Fix Pine64 Quartz4-B PMIC interrupt
commit: 562105c1b072411c71ac2202410d83ee79297624

Best regards,
--
Heiko Stuebner <[email protected]>