2022-11-07 09:39:49

by Katrin Jo

Subject: [PATCH] rtc: rzn1: Check return value in rzn1_rtc_probe

From: Yushan Zhou <[email protected]>

The rzn1_rtc_probe() function utilizes devm_pm_runtime_enable()
but wasn't checking the return value. Fix it by adding missing
check.

Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver")

Signed-off-by: Yushan Zhou <[email protected]>
---
drivers/rtc/rtc-rzn1.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c
index ac788799c8e3..0d36bc50197c 100644
--- a/drivers/rtc/rtc-rzn1.c
+++ b/drivers/rtc/rtc-rzn1.c
@@ -355,7 +355,9 @@ static int rzn1_rtc_probe(struct platform_device *pdev)
set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->rtcdev->features);
clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtcdev->features);

- devm_pm_runtime_enable(&pdev->dev);
+ ret = devm_pm_runtime_enable(&pdev->dev);
+ if (ret < 0)
+ return ret;
ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret < 0)
return ret;
--
2.27.0

2022-11-07 10:35:52

by Miquel Raynal

Subject: Re: [PATCH] rtc: rzn1: Check return value in rzn1_rtc_probe

Hello,

[email protected] wrote on Mon, 7 Nov 2022 17:25:44 +0800:

> From: Yushan Zhou <[email protected]>
>
> The rzn1_rtc_probe() function utilizes devm_pm_runtime_enable()
> but wasn't checking the return value. Fix it by adding missing
> check.
>
> Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver")
>
> Signed-off-by: Yushan Zhou <[email protected]>
> ---
> drivers/rtc/rtc-rzn1.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c
> index ac788799c8e3..0d36bc50197c 100644
> --- a/drivers/rtc/rtc-rzn1.c
> +++ b/drivers/rtc/rtc-rzn1.c
> @@ -355,7 +355,9 @@ static int rzn1_rtc_probe(struct platform_device *pdev)
> set_bit(RTC_FEATURE_ALARM_RES_MINUTE, rtc->rtcdev->features);
> clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->rtcdev->features);
>
> - devm_pm_runtime_enable(&pdev->dev);
> + ret = devm_pm_runtime_enable(&pdev->dev);
> + if (ret < 0)
> + return ret;
> ret = pm_runtime_resume_and_get(&pdev->dev);
> if (ret < 0)
> return ret;

Reviewed-by: Miquel Raynal <[email protected]>

Thanks,
Miquèl

2022-11-14 17:55:12

by Alexandre Belloni

Subject: Re: [PATCH] rtc: rzn1: Check return value in rzn1_rtc_probe

On Mon, 7 Nov 2022 17:25:44 +0800, [email protected] wrote:
> From: Yushan Zhou <[email protected]>
>
> The rzn1_rtc_probe() function utilizes devm_pm_runtime_enable()
> but wasn't checking the return value. Fix it by adding missing
> check.
>
> Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver")
>
> [...]

Applied, thanks!

[1/1] rtc: rzn1: Check return value in rzn1_rtc_probe
commit: 0ef7422f0f40423143b6488e52a30444f33cdc89

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com