2022-11-07 09:41:49

by Robert Marko

Subject: [PATCH 3/3] arm64: dts: qcom: hk01: use GPIO flags for tlmm

Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
harcoding the cell value.

Signed-off-by: Robert Marko <[email protected]>
---
arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
index b60b2d4c2ea5..c3f3f78271e9 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
+++ b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
@@ -4,6 +4,7 @@
*/
#include "ipq8074.dtsi"
#include "pmp8074.dtsi"
+#include <dt-bindings/gpio/gpio.h>

/ {
model = "Qualcomm Technologies, Inc. IPQ8074-HK01";
@@ -52,12 +53,12 @@ &blsp1_uart5 {

&pcie0 {
status = "okay";
- perst-gpios = <&tlmm 61 0x1>;
+ perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
};

&pcie1 {
status = "okay";
- perst-gpios = <&tlmm 58 0x1>;
+ perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
};

&pcie_phy0 {
--
2.38.1

2022-11-07 10:12:49

by Konrad Dybcio

Subject: Re: [PATCH 3/3] arm64: dts: qcom: hk01: use GPIO flags for tlmm

On 07/11/2022 10:29, Robert Marko wrote:
> Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
> harcoding the cell value.
>
> Signed-off-by: Robert Marko <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/ipq8074-hk01.dts | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
> index b60b2d4c2ea5..c3f3f78271e9 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk01.dts
> @@ -4,6 +4,7 @@
> */
> #include "ipq8074.dtsi"
> #include "pmp8074.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> model = "Qualcomm Technologies, Inc. IPQ8074-HK01";
> @@ -52,12 +53,12 @@ &blsp1_uart5 {
>
> &pcie0 {
> status = "okay";
> - perst-gpios = <&tlmm 61 0x1>;
> + perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
> };
>
> &pcie1 {
> status = "okay";
> - perst-gpios = <&tlmm 58 0x1>;
> + perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>;
> };
>
> &pcie_phy0 {

2022-11-07 10:39:13

by Krzysztof Kozlowski

Subject: Re: [PATCH 3/3] arm64: dts: qcom: hk01: use GPIO flags for tlmm

On 07/11/2022 10:29, Robert Marko wrote:
> Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of
> harcoding the cell value.
>
> Signed-off-by: Robert Marko <[email protected]>
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof