2022-11-07 16:00:57

by Inbaraj E

[permalink] [raw]
Subject: [PATCH v2] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1

Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.

"gout" is output of a gate clock.
Unlike any other clocks, the fsys1 mmc top clock does not have a divider.
So, it should be "mout -> gout" instead of "mout -> gout -> dout".

This fixes make dtbs_check warning as shown below:

arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: clock-controller@17040000:
clock-names:2: 'dout_clkcmu_fsys1_mmc_card' was expected
From schema: /home/inbaraj/mainline/linux/Documentation/devicetree/
bindings/clock/samsung,exynosautov9-clock.yaml

Fixes: 4b6ec8d88623 ("dt-bindings: clock: exynosautov9: add schema for cmu_fsys0/1")
Reviewed-by: Chanho Park <[email protected]>
Signed-off-by: Inbaraj E <[email protected]>
---
.../devicetree/bindings/clock/samsung,exynosautov9-clock.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
index 2ab4642679c0..55c4f94a14d1 100644
--- a/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov9-clock.yaml
@@ -148,7 +148,7 @@ allOf:
items:
- const: oscclk
- const: dout_clkcmu_fsys1_bus
- - const: dout_clkcmu_fsys1_mmc_card
+ - const: gout_clkcmu_fsys1_mmc_card
- const: dout_clkcmu_fsys1_usbdrd

- if:
--
2.17.1



2022-11-07 16:20:33

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1

On Mon, 7 Nov 2022 18:13:37 +0530, Inbaraj E wrote:
> Fix reference to CMU_FSYS1 mmc card clock to gout clock instead of dout.
>
> "gout" is output of a gate clock.
> Unlike any other clocks, the fsys1 mmc top clock does not have a divider.
> So, it should be "mout -> gout" instead of "mout -> gout -> dout".
>
> This fixes make dtbs_check warning as shown below:
>
> [...]

Applied, thanks!

[1/1] dt-bindings: clock: exynosautov9: fix reference to CMU_FSYS1
https://git.kernel.org/krzk/linux/c/4854e8b083d800b421c02d3a8482fbfe27fb33ec

Best regards,
--
Krzysztof Kozlowski <[email protected]>