2022-11-07 16:17:10

by Pierre Gondois

Subject: [PATCH v2 01/23] arm64: dts: Update cache properties for amazon

The DeviceTree Specification v0.3 specifies that the cache node
'compatible' and 'cache-level' properties are 'required'. Cf.
s3.8 Multi-level and Shared Cache Nodes
The 'cache-unified' property should be present if one of the
properties for unified cache is present ('cache-size', ...).

Update the Device Trees accordingly.

Signed-off-by: Pierre Gondois <[email protected]>
---
arch/arm64/boot/dts/amazon/alpine-v3.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/amazon/alpine-v3.dtsi b/arch/arm64/boot/dts/amazon/alpine-v3.dtsi
index 73a352ea8fd5..ba7e56dc85db 100644
--- a/arch/arm64/boot/dts/amazon/alpine-v3.dtsi
+++ b/arch/arm64/boot/dts/amazon/alpine-v3.dtsi
@@ -246,6 +246,7 @@ cpu@303 {

cluster0_l2: cache@0 {
compatible = "cache";
+ cache-unified;
cache-size = <0x200000>;
cache-line-size = <64>;
cache-sets = <2048>;
@@ -254,6 +255,7 @@ cluster0_l2: cache@0 {

cluster1_l2: cache@100 {
compatible = "cache";
+ cache-unified;
cache-size = <0x200000>;
cache-line-size = <64>;
cache-sets = <2048>;
@@ -262,6 +264,7 @@ cluster1_l2: cache@100 {

cluster2_l2: cache@200 {
compatible = "cache";
+ cache-unified;
cache-size = <0x200000>;
cache-line-size = <64>;
cache-sets = <2048>;
@@ -270,6 +273,7 @@ cluster2_l2: cache@200 {

cluster3_l2: cache@300 {
compatible = "cache";
+ cache-unified;
cache-size = <0x200000>;
cache-line-size = <64>;
cache-sets = <2048>;
--
2.25.1

2023-01-12 09:41:08

by Pierre Gondois

Subject: Re: [PATCH v2 01/23] arm64: dts: Update cache properties for amazon

(subset for cc list)
Hello,
Just a reminder in case the patch was forgotten,
Regards,
Pierre

On 11/7/22 16:56, Pierre Gondois wrote:
> The DeviceTree Specification v0.3 specifies that the cache node
> 'compatible' and 'cache-level' properties are 'required'. Cf.
> s3.8 Multi-level and Shared Cache Nodes
> The 'cache-unified' property should be present if one of the
> properties for unified cache is present ('cache-size', ...).
>
> Update the Device Trees accordingly.
>
> Signed-off-by: Pierre Gondois <[email protected]>
> ---
> arch/arm64/boot/dts/amazon/alpine-v3.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amazon/alpine-v3.dtsi b/arch/arm64/boot/dts/amazon/alpine-v3.dtsi
> index 73a352ea8fd5..ba7e56dc85db 100644
> --- a/arch/arm64/boot/dts/amazon/alpine-v3.dtsi
> +++ b/arch/arm64/boot/dts/amazon/alpine-v3.dtsi
> @@ -246,6 +246,7 @@ cpu@303 {
>
> cluster0_l2: cache@0 {
> compatible = "cache";
> + cache-unified;
> cache-size = <0x200000>;
> cache-line-size = <64>;
> cache-sets = <2048>;
> @@ -254,6 +255,7 @@ cluster0_l2: cache@0 {
>
> cluster1_l2: cache@100 {
> compatible = "cache";
> + cache-unified;
> cache-size = <0x200000>;
> cache-line-size = <64>;
> cache-sets = <2048>;
> @@ -262,6 +264,7 @@ cluster1_l2: cache@100 {
>
> cluster2_l2: cache@200 {
> compatible = "cache";
> + cache-unified;
> cache-size = <0x200000>;
> cache-line-size = <64>;
> cache-sets = <2048>;
> @@ -270,6 +273,7 @@ cluster2_l2: cache@200 {
>
> cluster3_l2: cache@300 {
> compatible = "cache";
> + cache-unified;
> cache-size = <0x200000>;
> cache-line-size = <64>;
> cache-sets = <2048>;