2022-11-08 14:49:55

by Chen Hui

Subject: [PATCH] arch: arm: Fix memory leak in realtime_counter_init()

The "sys_clk" resource is malloced by clk_get(),
it is not released when the function return.

Fixes: fa6d79d27614 ("ARM: OMAP: Add initialisation for the real-time counter.")
Signed-off-by: Chen Hui <[email protected]>
---
arch/arm/mach-omap2/timer.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
index 620ba69c8f11..5677c4a08f37 100644
--- a/arch/arm/mach-omap2/timer.c
+++ b/arch/arm/mach-omap2/timer.c
@@ -76,6 +76,7 @@ static void __init realtime_counter_init(void)
}

rate = clk_get_rate(sys_clk);
+ clk_put(sys_clk);

if (soc_is_dra7xx()) {
/*
--
2.17.1

2022-12-14 11:22:52

by Tony Lindgren

Subject: Re: [PATCH] arch: arm: Fix memory leak in realtime_counter_init()

* Chen Hui <[email protected]> [221108 15:40]:
> The "sys_clk" resource is malloced by clk_get(),
> it is not released when the function return.

Sorry for the delays, I'll apply this for v6.3 after v6.2-rc1
is available.

Regards,

Tony