2022-11-09 06:40:54

by Sibi Sankar

Subject: [PATCH V3 1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm reference boards as LTE

When the modem node was re-located to a separate LTE source file
"sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users
weren't marked appropriately. Fix this by marking all Qualcomm
reference devices as LTE.

Suggested-by: Douglas Anderson <[email protected]>
Fixes: d42fae738f3a ("arm64: dts: qcom: Add LTE SKUs for sc7280-villager family")
Signed-off-by: Sibi Sankar <[email protected]>
---

v3:
* Fix incorrect tag usage [Krzysztof]

arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index 4884647a8a95..ca09367abb6c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -13,6 +13,7 @@
#include "pmk8350.dtsi"

#include "sc7280-chrome-common.dtsi"
+#include "sc7280-herobrine-lte-sku.dtsi"

/ {
aliases {
--
2.17.1

2022-11-09 18:04:22

by Doug Anderson

Subject: Re: [PATCH V3 1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm reference boards as LTE

Hi,

On Tue, Nov 8, 2022 at 9:51 PM Sibi Sankar <[email protected]> wrote:
>
> When the modem node was re-located to a separate LTE source file
> "sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users
> weren't marked appropriately. Fix this by marking all Qualcomm
> reference devices as LTE.
>
> Suggested-by: Douglas Anderson <[email protected]>
> Fixes: d42fae738f3a ("arm64: dts: qcom: Add LTE SKUs for sc7280-villager family")
> Signed-off-by: Sibi Sankar <[email protected]>
> ---
>
> v3:
> * Fix incorrect tag usage [Krzysztof]
>
> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> index 4884647a8a95..ca09367abb6c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> @@ -13,6 +13,7 @@
> #include "pmk8350.dtsi"
>
> #include "sc7280-chrome-common.dtsi"
> +#include "sc7280-herobrine-lte-sku.dtsi"

I think you need to _remove_ the include from the "idp.dts" file now,
right? Otherwise it gets included twice.

2022-11-10 07:40:57

by Sibi Sankar

Subject: Re: [PATCH V3 1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm reference boards as LTE

Hey Doug,

Thanks for taking time to review the series.

On 11/9/22 23:10, Doug Anderson wrote:
> Hi,
>
> On Tue, Nov 8, 2022 at 9:51 PM Sibi Sankar <[email protected]> wrote:
>>
>> When the modem node was re-located to a separate LTE source file
>> "sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users
>> weren't marked appropriately. Fix this by marking all Qualcomm
>> reference devices as LTE.
>>
>> Suggested-by: Douglas Anderson <[email protected]>
>> Fixes: d42fae738f3a ("arm64: dts: qcom: Add LTE SKUs for sc7280-villager family")
>> Signed-off-by: Sibi Sankar <[email protected]>
>> ---
>>
>> v3:
>> * Fix incorrect tag usage [Krzysztof]
>>
>> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> index 4884647a8a95..ca09367abb6c 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> @@ -13,6 +13,7 @@
>> #include "pmk8350.dtsi"
>>
>> #include "sc7280-chrome-common.dtsi"
>> +#include "sc7280-herobrine-lte-sku.dtsi"
>
> I think you need to _remove_ the include from the "idp.dts" file now,
> right? Otherwise it gets included twice.

sry missed ^^, will fix it in the re-spin.

- Sibi