2022-11-10 05:40:30

by Thomas Weißschuh

Subject: [PATCH] nbd: automatically load module on genl access

Instead of forcing the user to manually load the module do it
automatically.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
drivers/block/nbd.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 5cffd96ef2d7..1c38a7ea9531 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -2328,6 +2328,7 @@ static struct genl_family nbd_genl_family __ro_after_init = {
.mcgrps = nbd_mcast_grps,
.n_mcgrps = ARRAY_SIZE(nbd_mcast_grps),
};
+MODULE_ALIAS_GENL_FAMILY(NBD_GENL_FAMILY_NAME);

static int populate_nbd_status(struct nbd_device *nbd, struct sk_buff *reply)
{

base-commit: f67dd6ce0723ad013395f20a3f79d8a437d3f455
--
2.38.1

2023-01-11 17:08:03

by Thomas Weißschuh

Subject: Re: [PATCH] nbd: automatically load module on genl access

Hi,

On Thu, Nov 10, 2022 at 06:24:38AM +0100, Thomas Wei?schuh wrote:
> Instead of forcing the user to manually load the module do it
> automatically.
>
> Signed-off-by: Thomas Wei?schuh <[email protected]>
> ---
> drivers/block/nbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> index 5cffd96ef2d7..1c38a7ea9531 100644
> --- a/drivers/block/nbd.c
> +++ b/drivers/block/nbd.c
> @@ -2328,6 +2328,7 @@ static struct genl_family nbd_genl_family __ro_after_init = {
> .mcgrps = nbd_mcast_grps,
> .n_mcgrps = ARRAY_SIZE(nbd_mcast_grps),
> };
> +MODULE_ALIAS_GENL_FAMILY(NBD_GENL_FAMILY_NAME);
>
> static int populate_nbd_status(struct nbd_device *nbd, struct sk_buff *reply)
> {
>
> base-commit: f67dd6ce0723ad013395f20a3f79d8a437d3f455
> --
> 2.38.1
>

Any feedback on the patch?

Thanks,
Thomas

2023-04-27 06:24:46

by Thomas Weißschuh

Subject: Re: [PATCH] nbd: automatically load module on genl access

Hi Josef,

could you take a look at this?

... ping

Thanks,
Thomas

On 2022-11-10 06:24:38+0100, Thomas Weißschuh wrote:
> Instead of forcing the user to manually load the module do it
> automatically.
>
> Signed-off-by: Thomas Weißschuh <[email protected]>
> ---
> drivers/block/nbd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> index 5cffd96ef2d7..1c38a7ea9531 100644
> --- a/drivers/block/nbd.c
> +++ b/drivers/block/nbd.c
> @@ -2328,6 +2328,7 @@ static struct genl_family nbd_genl_family __ro_after_init = {
> .mcgrps = nbd_mcast_grps,
> .n_mcgrps = ARRAY_SIZE(nbd_mcast_grps),
> };
> +MODULE_ALIAS_GENL_FAMILY(NBD_GENL_FAMILY_NAME);
>
> static int populate_nbd_status(struct nbd_device *nbd, struct sk_buff *reply)
> {
>
> base-commit: f67dd6ce0723ad013395f20a3f79d8a437d3f455
> --
> 2.38.1
>