2022-11-10 12:22:31

by Wangshaobo (bobo)

Subject: [PATCH] mISDN: fix misuse of put_device() in mISDN_register_device()

We should not release reference by put_device() before calling device_initialize().

Fixes: e7d1d4d9ac0d ("mISDN: fix possible memory leak in mISDN_register_device()")
Signed-off-by: Wang ShaoBo <[email protected]>
---
drivers/isdn/mISDN/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/isdn/mISDN/core.c b/drivers/isdn/mISDN/core.c
index 7ea0100f218a..90ee56d07a6e 100644
--- a/drivers/isdn/mISDN/core.c
+++ b/drivers/isdn/mISDN/core.c
@@ -222,7 +222,7 @@ mISDN_register_device(struct mISDNdevice *dev,

err = get_free_devid();
if (err < 0)
- goto error1;
+ return err;
dev->id = err;

device_initialize(&dev->dev);
--
2.25.1

2022-11-14 10:54:20

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] mISDN: fix misuse of put_device() in mISDN_register_device()

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Thu, 10 Nov 2022 19:38:23 +0800 you wrote:
> We should not release reference by put_device() before calling device_initialize().
>
> Fixes: e7d1d4d9ac0d ("mISDN: fix possible memory leak in mISDN_register_device()")
> Signed-off-by: Wang ShaoBo <[email protected]>
> ---
> drivers/isdn/mISDN/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- mISDN: fix misuse of put_device() in mISDN_register_device()
https://git.kernel.org/netdev/net/c/2d25107e111a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html