2022-11-10 12:24:32

by Lin Ma

Subject: [PATCH v1] io_uring: update outdated comment of callbacks

Previous commit ebc11b6c6b87 ("io_uring: clean io-wq callbacks") rename
io_free_work() into io_wq_free_work() for consistency. This patch also
updates relevant comment to avoid misunderstanding.

Fixes: ebc11b6c6b87 ("io_uring: clean io-wq callbacks")
Signed-off-by: Lin Ma <[email protected]>
---
io_uring/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index ac8c488e3077..a1024b7fcc73 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -1782,7 +1782,7 @@ void io_wq_submit_work(struct io_wq_work *work)
bool needs_poll = false;
int ret = 0, err = -ECANCELED;

- /* one will be dropped by ->io_free_work() after returning to io-wq */
+ /* one will be dropped by ->io_wq_free_work() after returning to io-wq */
if (!(req->flags & REQ_F_REFCOUNT))
__io_req_set_refcount(req, 2);
else
--
2.38.1

2022-11-10 18:34:12

by Jens Axboe

Subject: Re: [PATCH v1] io_uring: update outdated comment of callbacks

On Thu, 10 Nov 2022 20:21:03 +0800, Lin Ma wrote:
> Previous commit ebc11b6c6b87 ("io_uring: clean io-wq callbacks") rename
> io_free_work() into io_wq_free_work() for consistency. This patch also
> updates relevant comment to avoid misunderstanding.
>
>

Applied, thanks!

[1/1] io_uring: update outdated comment of callbacks
commit: 55acb7980966a3a007af6173910c7aa7b600226f

Best regards,
--
Jens Axboe