2022-11-10 18:05:00

by Vincent Knecht

[permalink] [raw]
Subject: [PATCH v4 0/5] Input: msg2638: Add support for msg2138 and key

This is a resend of [1] with no changes, like v3 which didn't mae it to
mailing lists for some reason.

This series:
- moves max fingers number and irqhandler settings in a struct
- adds support for msg2138 touchscreen
- adds support for buttons, which were only seen with msg2138 as of yet

Big thanks to Stephan Gerhold <[email protected]> for the help with
deciphering the downstream driver [2] and writing clean and working code.

[1] https://lore.kernel.org/linux-input/[email protected]/
[2] https://github.com/LineageOS/android_kernel_huawei_msm8916/blob/2f24fa58086a969687434b40f237cb589a1f324f/drivers/input/touchscreen/mstar/msg2138_qc.c

Vincent Knecht (5):
Input: msg2638 - Set max finger number and irqhandler from driver data
dt-bindings: input: touchscreen: msg2638: Document msg2138 support
Input: msg2638 - Add support for msg2138
dt-bindings: input: touchscreen: msg2638: Document keys support
Input: msg2638 - Add support for msg2138 key events

.../input/touchscreen/mstar,msg2638.yaml | 8 +-
drivers/input/touchscreen/msg2638.c | 182 ++++++++++++++++--
2 files changed, 175 insertions(+), 15 deletions(-)

--
2.38.1





2022-11-10 18:35:23

by Vincent Knecht

[permalink] [raw]
Subject: [PATCH v4 2/5] dt-bindings: input: touchscreen: msg2638: Document msg2138 support

Document msg2138 support by adding mstar,msg2138 compatible.

Acked-by: Rob Herring <[email protected]>
Signed-off-by: Vincent Knecht <[email protected]>
---
.../devicetree/bindings/input/touchscreen/mstar,msg2638.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/mstar,msg2638.yaml b/Documentation/devicetree/bindings/input/touchscreen/mstar,msg2638.yaml
index 3a42c23faf6f..2fb7e01bb65a 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/mstar,msg2638.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/mstar,msg2638.yaml
@@ -14,7 +14,9 @@ allOf:

properties:
compatible:
- const: mstar,msg2638
+ enum:
+ - mstar,msg2138
+ - mstar,msg2638

reg:
const: 0x26
--
2.38.1




2022-11-15 01:31:52

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH v4 2/5] dt-bindings: input: touchscreen: msg2638: Document msg2138 support

On Thu, Nov 10, 2022 at 06:19:45PM +0100, Vincent Knecht wrote:
> Document msg2138 support by adding mstar,msg2138 compatible.
>
> Acked-by: Rob Herring <[email protected]>
> Signed-off-by: Vincent Knecht <[email protected]>

Applied, thank you.

--
Dmitry