2022-11-10 09:44:21

by ye.xingchen

Subject: [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource()

From: Minghao Chi <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/dma/bcm2835-dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 630dfbb01a40..1547f528a58e 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -902,8 +902,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)

dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF);

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(&pdev->dev, res);
+ base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(base))
return PTR_ERR(base);

--
2.25.1

2022-11-10 12:11:16

by Mukesh Ojha

Subject: Re: [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource()

Hi,

On 11/10/2022 2:56 PM, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> drivers/dma/bcm2835-dma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 630dfbb01a40..1547f528a58e 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -902,8 +902,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
>
> dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(base))
> return PTR_ERR(base);
>

LGTM.
Reviewed-by: Mukesh Ojha <[email protected]>


-Mukesh

2022-11-10 17:07:15

by Tudor Ambarus

Subject: Re: [PATCH] dmaengine: use devm_platform_get_and_ioremap_resource()

On 11/10/22 11:26, [email protected] wrote:
> [You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Minghao Chi <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.

Would you review my v3 instead?
https://lore.kernel.org/lkml/[email protected]/

The intention is to do this small change for all the dma drivers in a
single patch, so that we don't pollute the commit log.

>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Minghao Chi <[email protected]>
> ---
> drivers/dma/bcm2835-dma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 630dfbb01a40..1547f528a58e 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -902,8 +902,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
>
> dma_set_max_seg_size(&pdev->dev, 0x3FFFFFFF);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - base = devm_ioremap_resource(&pdev->dev, res);
> + base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(base))
> return PTR_ERR(base);
>
> --
> 2.25.1
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
Cheers,
ta