This patch series adds new compatible for Exynos3250 along with its
driver variant data for MFC v7 hardware.
Since,MFC v7 support was added for Exynos5420 and Exynos
3250 SoC with same compatible string "samsung,mfc-v7".As
both SoCs having different hardware properties and having
same compatible string for both SoCs doesn't seems to be correct.
So ,new compatible is added for Exynos3250 SOC which will
differentiate the node properties for both SoCs which
support MFC v7.
Changes since v2:
- Addressed review comments from Krzysztof Kozlowski[1].
Changes since v1:
- Addressed review comments from Marek Szyprowski[2].
- Addressed review comments from Krzysztof Kozlowski[3].
- Addressed review comments from Tommaso Merciai[4].
1-https://patchwork.kernel.org/project/linux-media/patch/[email protected]/#25081990
2-https://patchwork.kernel.org/project/linux-media/patch/[email protected]/#25072873
3-https://patchwork.kernel.org/project/linux-media/patch/[email protected]/#25073109
4-https://patchwork.kernel.org/project/linux-media/patch/[email protected]/#25072977
Aakarsh Jain (3):
media: dt-bindings: s5p-mfc: Add new compatible string for Exynos3250
SoC.
media: s5p-mfc:Add variant data for MFC v7 hardware for Exynos 3250
SoC
ARM: dts: exynos: Rename compatible string property from version to
SoC specific
.../devicetree/bindings/media/s5p-mfc.txt | 9 +++++----
arch/arm/boot/dts/exynos3250.dtsi | 2 +-
.../media/platform/samsung/s5p-mfc/s5p_mfc.c | 17 +++++++++++++++--
3 files changed, 21 insertions(+), 7 deletions(-)
--
2.17.1
commit "5441e9dafdfc6dc40fa" which adds mfc v7 support for
Exynos3250 and use the same compatible string as used by
Exynos5240 but both the IPs are a bit different in terms of
IP clock.
Lets add variant driver data based on the new compatible string
"samsung,exynos3250-mfc" for Exynos3250 SoC.
Suggested-by: Alim Akhtar <[email protected]>
Fixes: 5441e9dafdfc ("[media] s5p-mfc: Core support for MFC v7")
Signed-off-by: Aakarsh Jain <[email protected]>
---
.../media/platform/samsung/s5p-mfc/s5p_mfc.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
index fca5c6405eec..007c7dbee037 100644
--- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc.c
@@ -1576,8 +1576,18 @@ static struct s5p_mfc_variant mfc_drvdata_v7 = {
.port_num = MFC_NUM_PORTS_V7,
.buf_size = &buf_size_v7,
.fw_name[0] = "s5p-mfc-v7.fw",
- .clk_names = {"mfc", "sclk_mfc"},
- .num_clocks = 2,
+ .clk_names = {"mfc"},
+ .num_clocks = 1,
+};
+
+static struct s5p_mfc_variant mfc_drvdata_v7_3250 = {
+ .version = MFC_VERSION_V7,
+ .version_bit = MFC_V7_BIT,
+ .port_num = MFC_NUM_PORTS_V7,
+ .buf_size = &buf_size_v7,
+ .fw_name[0] = "s5p-mfc-v7.fw",
+ .clk_names = {"mfc", "sclk_mfc"},
+ .num_clocks = 2,
};
static struct s5p_mfc_buf_size_v6 mfc_buf_size_v8 = {
@@ -1647,6 +1657,9 @@ static const struct of_device_id exynos_mfc_match[] = {
}, {
.compatible = "samsung,mfc-v7",
.data = &mfc_drvdata_v7,
+ }, {
+ .compatible = "samsung,exynos3250-mfc",
+ .data = &mfc_drvdata_v7_3250,
}, {
.compatible = "samsung,mfc-v8",
.data = &mfc_drvdata_v8,
--
2.17.1
On 11/11/2022 04:23, Aakarsh Jain wrote:
> This patch series adds new compatible for Exynos3250 along with its
> driver variant data for MFC v7 hardware.
> Since,MFC v7 support was added for Exynos5420 and Exynos
> 3250 SoC with same compatible string "samsung,mfc-v7".As
> both SoCs having different hardware properties and having
> same compatible string for both SoCs doesn't seems to be correct.
> So ,new compatible is added for Exynos3250 SOC which will
> differentiate the node properties for both SoCs which
> support MFC v7.
>
> Changes since v2:
> - Addressed review comments from Krzysztof Kozlowski[1].
What changed exactly?
>
> Changes since v1:
> - Addressed review comments from Marek Szyprowski[2].
> - Addressed review comments from Krzysztof Kozlowski[3].
> - Addressed review comments from Tommaso Merciai[4].
What changed exactly?
Best regards,
Krzysztof