Since,MFC v7 support was added for Exynos5420 and Exynos
3250 SoC with same compatible string "samsung,mfc-v7".As
both SoCs having different hardware properties and having
same compatible string for both SoCs doesn't seems to be correct.
New compatible is added for Exynos3250 SOC which will
differentiate the node properties for both SoCs which
support MFC v7.
Reviewed-by: Tommaso Merciai <[email protected]>
Suggested-by: Alim Akhtar <[email protected]>
Signed-off-by: Aakarsh Jain <[email protected]>
---
Documentation/devicetree/bindings/media/s5p-mfc.txt | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
We are already in process of converting this txt file to yaml.
https://patchwork.kernel.org/project/linux-media/patch/[email protected]/
Modifying this txt binding for completeness.
diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Documentation/devicetree/bindings/media/s5p-mfc.txt
index aa54c8159d9f..cb166654fa81 100644
--- a/Documentation/devicetree/bindings/media/s5p-mfc.txt
+++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt
@@ -10,10 +10,11 @@ Required properties:
- compatible : value should be either one among the following
(a) "samsung,mfc-v5" for MFC v5 present in Exynos4 SoCs
(b) "samsung,mfc-v6" for MFC v6 present in Exynos5 SoCs
- (c) "samsung,mfc-v7" for MFC v7 present in Exynos5420 SoC
- (d) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC
- (e) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC
- (f) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC
+ (c) "samsung,exynos3250-mfc" for MFC v7 present in Exynos3250 SoC
+ (d) "samsung,mfc-v7" for MFC v7 present in Exynos5420 SoC
+ (e) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC
+ (f) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC
+ (g) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC
- reg : Physical base address of the IP registers and length of memory
mapped region.
--
2.17.1
On 11/11/2022 04:23, Aakarsh Jain wrote:
> Since,MFC v7 support was added for Exynos5420 and Exynos
> 3250 SoC with same compatible string "samsung,mfc-v7".As
> both SoCs having different hardware properties and having
> same compatible string for both SoCs doesn't seems to be correct.
> New compatible is added for Exynos3250 SOC which will
> differentiate the node properties for both SoCs which
> support MFC v7.
Subject: Drop full stop from subject.
Commit: This is not correct formatting, nor wrapping. In English after
every comma or full stop there is a space.
Please wrap commit message according to Linux coding style / submission
process:
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
Not "is added" but just "Add new compatible"
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
But what is more important:
>
> Reviewed-by: Tommaso Merciai <[email protected]>
> Suggested-by: Alim Akhtar <[email protected]>
> Signed-off-by: Aakarsh Jain <[email protected]>
> ---
> Documentation/devicetree/bindings/media/s5p-mfc.txt | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> We are already in process of converting this txt file to yaml.
> https://patchwork.kernel.org/project/linux-media/patch/[email protected]/
> Modifying this txt binding for completeness.
>
> diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Documentation/devicetree/bindings/media/s5p-mfc.txt
> index aa54c8159d9f..cb166654fa81 100644
> --- a/Documentation/devicetree/bindings/media/s5p-mfc.txt
> +++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt
> @@ -10,10 +10,11 @@ Required properties:
> - compatible : value should be either one among the following
> (a) "samsung,mfc-v5" for MFC v5 present in Exynos4 SoCs
> (b) "samsung,mfc-v6" for MFC v6 present in Exynos5 SoCs
> - (c) "samsung,mfc-v7" for MFC v7 present in Exynos5420 SoC
> - (d) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC
> - (e) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC
> - (f) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC
> + (c) "samsung,exynos3250-mfc" for MFC v7 present in Exynos3250 SoC
> + (d) "samsung,mfc-v7" for MFC v7 present in Exynos5420 SoC
> + (e) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC
> + (f) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC
> + (g) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC
I don't see here any improvements about which I commented since v1.
Best regards,
Krzysztof