2022-11-11 09:14:05

by Michael Straube

Subject: [PATCH 0/4] staging: r8188eu: some _FAIL, _SUCCESS removals

This series removes some more uses of _FAIL and _SUCCESS.
Tested on x86_64 with Inter-Tech DMG-02.

Michael Straube (4):
staging: r8188eu: convert aes_cipher() to void
staging: r8188eu: convert rtw_xmit_resource_alloc() to common error
logic
staging: r8188eu: convert _rtw_init_xmit_priv() to common error logic
staging: r8188eu: binstallGrpkey is set to _FAIL

drivers/staging/r8188eu/core/rtw_security.c | 4 +--
drivers/staging/r8188eu/core/rtw_xmit.c | 37 +++++++--------------
drivers/staging/r8188eu/include/rtw_xmit.h | 2 +-
drivers/staging/r8188eu/os_dep/os_intfs.c | 4 +--
4 files changed, 16 insertions(+), 31 deletions(-)

--
2.38.1

2022-11-11 09:18:21

by Michael Straube

Subject: [PATCH 4/4] staging: r8188eu: binstallGrpkey is set to _FAIL

The variable binstallGrpkey is set to _FAIL which is defined as 0.
Use false to set the variable to get rid of another use of _FAIL.

Signed-off-by: Michael Straube <[email protected]>
---
drivers/staging/r8188eu/os_dep/os_intfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c
index 44eb95a7682c..2f59bb994796 100644
--- a/drivers/staging/r8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/r8188eu/os_dep/os_intfs.c
@@ -405,7 +405,7 @@ static void rtw_init_default_value(struct adapter *padapter)
pmlmepriv->htpriv.ampdu_enable = false;/* set to disabled */

/* security_priv */
- psecuritypriv->binstallGrpkey = _FAIL;
+ psecuritypriv->binstallGrpkey = false;
psecuritypriv->sw_encrypt = pregistrypriv->software_encrypt;
psecuritypriv->sw_decrypt = pregistrypriv->software_decrypt;
psecuritypriv->dot11AuthAlgrthm = dot11AuthAlgrthm_Open; /* open system */
--
2.38.1

2022-11-11 18:56:27

by Philipp Hortmann

Subject: Re: [PATCH 0/4] staging: r8188eu: some _FAIL, _SUCCESS removals

On 11/11/22 09:37, Michael Straube wrote:
> This series removes some more uses of _FAIL and _SUCCESS.
> Tested on x86_64 with Inter-Tech DMG-02.
>
> Michael Straube (4):
> staging: r8188eu: convert aes_cipher() to void
> staging: r8188eu: convert rtw_xmit_resource_alloc() to common error
> logic
> staging: r8188eu: convert _rtw_init_xmit_priv() to common error logic
> staging: r8188eu: binstallGrpkey is set to _FAIL
>
> drivers/staging/r8188eu/core/rtw_security.c | 4 +--
> drivers/staging/r8188eu/core/rtw_xmit.c | 37 +++++++--------------
> drivers/staging/r8188eu/include/rtw_xmit.h | 2 +-
> drivers/staging/r8188eu/os_dep/os_intfs.c | 4 +--
> 4 files changed, 16 insertions(+), 31 deletions(-)
>

Tested-by: Philipp Hortmann <[email protected]> # Edimax N150