2022-11-11 09:44:05

by xu xin

Subject: [PATCH linux-next] ipasdv4/tcp_ipv4: remove redundant assignment

From: xu xin <[email protected]>

The value of 'st->state' has been verified as "TCP_SEQ_STATE_LISTENING",
it's unnecessary to assign TCP_SEQ_STATE_LISTENING to it, so we can remove it.

Signed-off-by: xu xin <[email protected]>
---
net/ipv4/tcp_ipv4.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 7a250ef9d1b7..0180f3cefa9c 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -2478,7 +2478,6 @@ static void *tcp_seek_last_pos(struct seq_file *seq)
case TCP_SEQ_STATE_LISTENING:
if (st->bucket > hinfo->lhash2_mask)
break;
- st->state = TCP_SEQ_STATE_LISTENING;
rc = listening_get_first(seq);
while (offset-- && rc && bucket == st->bucket)
rc = listening_get_next(seq, rc);
--
2.25.1

2022-11-14 12:08:36

by patchwork-bot+netdevbpf

Subject: Re: [PATCH linux-next] ipasdv4/tcp_ipv4: remove redundant assignment

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Fri, 11 Nov 2022 09:04:20 +0000 you wrote:
> From: xu xin <[email protected]>
>
> The value of 'st->state' has been verified as "TCP_SEQ_STATE_LISTENING",
> it's unnecessary to assign TCP_SEQ_STATE_LISTENING to it, so we can remove it.
>
> Signed-off-by: xu xin <[email protected]>
>
> [...]

Here is the summary with links:
- [linux-next] ipasdv4/tcp_ipv4: remove redundant assignment
https://git.kernel.org/netdev/net-next/c/2fd450cd83e3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html