2022-11-11 10:25:08

by Jim Lin

[permalink] [raw]
Subject: [PATCH v7 2/3] xhci: hub: export symbol on xhci_hub_control

XHCI host drivers may override the default xhci_hub_control() with
their own device specific function. To allow these host drivers to
call the xhci_hub_control() function from within their own
hub_control() callback and be built as a module, export the symbol
for xhci_hub_control.

Signed-off-by: Jim Lin <[email protected]>

---
v5: new change
v6: modify commit message
v7: change commit message

drivers/usb/host/xhci-hub.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index af946c42b6f0..4f20cdae2a89 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers/usb/host/xhci-hub.c
@@ -1604,6 +1604,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
spin_unlock_irqrestore(&xhci->lock, flags);
return retval;
}
+EXPORT_SYMBOL_GPL(xhci_hub_control);

/*
* Returns 0 if the status hasn't changed, or the number of bytes in buf.
--
2.17.1



2022-11-11 15:19:30

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH v7 2/3] xhci: hub: export symbol on xhci_hub_control


On 11/11/2022 10:18, Jim Lin wrote:
> XHCI host drivers may override the default xhci_hub_control() with
> their own device specific function. To allow these host drivers to
> call the xhci_hub_control() function from within their own
> hub_control() callback and be built as a module, export the symbol
> for xhci_hub_control.
>
> Signed-off-by: Jim Lin <[email protected]>
>
> ---
> v5: new change
> v6: modify commit message
> v7: change commit message
>
> drivers/usb/host/xhci-hub.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
> index af946c42b6f0..4f20cdae2a89 100644
> --- a/drivers/usb/host/xhci-hub.c
> +++ b/drivers/usb/host/xhci-hub.c
> @@ -1604,6 +1604,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
> spin_unlock_irqrestore(&xhci->lock, flags);
> return retval;
> }
> +EXPORT_SYMBOL_GPL(xhci_hub_control);
>
> /*
> * Returns 0 if the status hasn't changed, or the number of bytes in buf.

Reviewed-by: Jon Hunter <[email protected]>
Tested-by: Jon Hunter <[email protected]>

Thanks
Jon

--
nvpublic

2022-11-17 22:41:02

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH v7 2/3] xhci: hub: export symbol on xhci_hub_control

On Fri, Nov 11, 2022 at 06:18:12PM +0800, Jim Lin wrote:
> XHCI host drivers may override the default xhci_hub_control() with
> their own device specific function. To allow these host drivers to
> call the xhci_hub_control() function from within their own
> hub_control() callback and be built as a module, export the symbol
> for xhci_hub_control.
>
> Signed-off-by: Jim Lin <[email protected]>
>
> ---
> v5: new change
> v6: modify commit message
> v7: change commit message
>
> drivers/usb/host/xhci-hub.c | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: Thierry Reding <[email protected]>


Attachments:
(No filename) (617.00 B)
signature.asc (849.00 B)
Download all attachments