2022-11-11 13:57:51

by Thomas Gleixner

Subject: [patch 08/39] genirq/msi: Provide msi_domain_ops::post_free()

To prepare for removing the exposure of __msi_domain_free_irqs() provide a
post_free() callback in the MSI domain ops which can be used to solve
the problem of the only user of __msi_domain_free_irqs() in arch/powerpc.

Signed-off-by: Thomas Gleixner <[email protected]>
---
include/linux/msi.h | 4 ++++
kernel/irq/msi.c | 2 ++
2 files changed, 6 insertions(+)

--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -315,6 +315,8 @@ struct msi_domain_info;
* function.
* @domain_free_irqs: Optional function to override the default free
* function.
+ * @msi_post_free: Optional function which is invoked after freeing
+ * all interrupts.
*
* @get_hwirq, @msi_init and @msi_free are callbacks used by the underlying
* irqdomain.
@@ -359,6 +361,8 @@ struct msi_domain_ops {
struct device *dev, int nvec);
void (*domain_free_irqs)(struct irq_domain *domain,
struct device *dev);
+ void (*msi_post_free)(struct irq_domain *domain,
+ struct device *dev);
};

/**
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -1026,6 +1026,8 @@ void msi_domain_free_irqs_descs_locked(s
lockdep_assert_held(&dev->msi.data->mutex);

ops->domain_free_irqs(domain, dev);
+ if (ops->msi_post_free)
+ ops->msi_post_free(domain, dev);
msi_domain_free_msi_descs(info, dev);
}

2022-11-16 17:49:39

by Jason Gunthorpe

Subject: Re: [patch 08/39] genirq/msi: Provide msi_domain_ops::post_free()

On Fri, Nov 11, 2022 at 02:54:27PM +0100, Thomas Gleixner wrote:
> To prepare for removing the exposure of __msi_domain_free_irqs() provide a
> post_free() callback in the MSI domain ops which can be used to solve
> the problem of the only user of __msi_domain_free_irqs() in arch/powerpc.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> ---
> include/linux/msi.h | 4 ++++
> kernel/irq/msi.c | 2 ++
> 2 files changed, 6 insertions(+)

Make sense, but I do wonder why PPC needs this ordering..

Reviewed-by: Jason Gunthorpe <[email protected]>

Jason

2022-11-16 23:09:58

by Thomas Gleixner

Subject: Re: [patch 08/39] genirq/msi: Provide msi_domain_ops::post_free()

On Wed, Nov 16 2022 at 13:44, Jason Gunthorpe wrote:
> On Fri, Nov 11, 2022 at 02:54:27PM +0100, Thomas Gleixner wrote:
>> To prepare for removing the exposure of __msi_domain_free_irqs() provide a
>> post_free() callback in the MSI domain ops which can be used to solve
>> the problem of the only user of __msi_domain_free_irqs() in arch/powerpc.
>>
>> Signed-off-by: Thomas Gleixner <[email protected]>
>> ---
>> include/linux/msi.h | 4 ++++
>> kernel/irq/msi.c | 2 ++
>> 2 files changed, 6 insertions(+)
>
> Make sense, but I do wonder why PPC needs this ordering..

Some hypervisor thing.

2022-11-17 15:22:48

by tip-bot2 for Alexey Makhalov

Subject: [tip: irq/core] genirq/msi: Provide msi_domain_ops:: Post_free()

The following commit has been merged into the irq/core branch of tip:

Commit-ID: f6d3486a3d2f3c67d732641834eec872fcc66472
Gitweb: https://git.kernel.org/tip/f6d3486a3d2f3c67d732641834eec872fcc66472
Author: Thomas Gleixner <[email protected]>
AuthorDate: Fri, 11 Nov 2022 14:54:27 +01:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Thu, 17 Nov 2022 15:15:19 +01:00

genirq/msi: Provide msi_domain_ops:: Post_free()

To prepare for removing the exposure of __msi_domain_free_irqs() provide a
post_free() callback in the MSI domain ops which can be used to solve
the problem of the only user of __msi_domain_free_irqs() in arch/powerpc.

Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Ashok Raj <[email protected]>
Reviewed-by: Jason Gunthorpe <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

---
include/linux/msi.h | 4 ++++
kernel/irq/msi.c | 2 ++
2 files changed, 6 insertions(+)

diff --git a/include/linux/msi.h b/include/linux/msi.h
index 9b552ee..7f6aba9 100644
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -315,6 +315,8 @@ struct msi_domain_info;
* function.
* @domain_free_irqs: Optional function to override the default free
* function.
+ * @msi_post_free: Optional function which is invoked after freeing
+ * all interrupts.
*
* @get_hwirq, @msi_init and @msi_free are callbacks used by the underlying
* irqdomain.
@@ -359,6 +361,8 @@ struct msi_domain_ops {
struct device *dev, int nvec);
void (*domain_free_irqs)(struct irq_domain *domain,
struct device *dev);
+ void (*msi_post_free)(struct irq_domain *domain,
+ struct device *dev);
};

/**
diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index 3ccc7f6..c71c37d 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -1026,6 +1026,8 @@ void msi_domain_free_irqs_descs_locked(struct irq_domain *domain, struct device
lockdep_assert_held(&dev->msi.data->mutex);

ops->domain_free_irqs(domain, dev);
+ if (ops->msi_post_free)
+ ops->msi_post_free(domain, dev);
msi_domain_free_msi_descs(info, dev);
}