2022-11-11 06:59:59

by ye.xingchen

Subject: [PATCH] usb: ehci-orion: use devm_platform_get_and_ioremap_resource()

From: Minghao Chi <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Minghao Chi <[email protected]>
---
drivers/usb/host/ehci-orion.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
index a3454a3ea4e0..d0970caf3c3a 100644
--- a/drivers/usb/host/ehci-orion.c
+++ b/drivers/usb/host/ehci-orion.c
@@ -234,8 +234,7 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
if (err)
goto err;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- regs = devm_ioremap_resource(&pdev->dev, res);
+ regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(regs)) {
err = PTR_ERR(regs);
goto err;
--
2.25.1

2022-11-15 10:39:21

by Greg Kroah-Hartman

Subject: Re: [PATCH] usb: ehci-orion: use devm_platform_get_and_ioremap_resource()

On Fri, Nov 11, 2022 at 02:33:14PM +0800, [email protected] wrote:
> From: Minghao Chi <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Reported-by: Zeal Robot <[email protected]>

You did not follow the rules when using a tool to find and fix problems,
please read the documentation for how to do so correctly.

> Signed-off-by: Minghao Chi <[email protected]>

Your email is showing up as being invalid, and spoofed, please work with
your domain to properly handle verified email otherwise it will not be
able to be accepted.

thanks,

greg k-h