2022-11-12 21:46:39

by Gabriel L. Somlo

Subject: [PATCH v3 06/14] serial: liteuart: move tty_flip_buffer_push() out of rx loop

Calling tty_flip_buffer_push() for each individual received character
is overkill. Move it out of the rx loop, and only call it once per
set of characters received together.

Signed-off-by: Gabriel Somlo <[email protected]>
---
drivers/tty/serial/liteuart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
index 047d5ad32e13..ff3486860989 100644
--- a/drivers/tty/serial/liteuart.c
+++ b/drivers/tty/serial/liteuart.c
@@ -86,10 +86,10 @@ static void liteuart_timer(struct timer_list *t)
/* no overflow bits in status */
if (!(uart_handle_sysrq_char(port, ch)))
uart_insert_char(port, status, 0, ch, flg);
-
- tty_flip_buffer_push(&port->state->port);
}

+ tty_flip_buffer_push(&port->state->port);
+
mod_timer(&uart->timer, jiffies + uart_poll_timeout(port));
}

--
2.37.3

2022-11-15 15:49:57

by Ilpo Järvinen

Subject: Re: [PATCH v3 06/14] serial: liteuart: move tty_flip_buffer_push() out of rx loop

On Sat, 12 Nov 2022, Gabriel Somlo wrote:

> Calling tty_flip_buffer_push() for each individual received character
> is overkill. Move it out of the rx loop, and only call it once per
> set of characters received together.
>
> Signed-off-by: Gabriel Somlo <[email protected]>
> ---
> drivers/tty/serial/liteuart.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> index 047d5ad32e13..ff3486860989 100644
> --- a/drivers/tty/serial/liteuart.c
> +++ b/drivers/tty/serial/liteuart.c
> @@ -86,10 +86,10 @@ static void liteuart_timer(struct timer_list *t)
> /* no overflow bits in status */
> if (!(uart_handle_sysrq_char(port, ch)))
> uart_insert_char(port, status, 0, ch, flg);
> -
> - tty_flip_buffer_push(&port->state->port);
> }
>
> + tty_flip_buffer_push(&port->state->port);
> +
> mod_timer(&uart->timer, jiffies + uart_poll_timeout(port));
> }

Reviewed-by: Ilpo J?rvinen <[email protected]>

--
i.